fix: avg cpu row incorrect height #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebp
force-pushed
the
zeb/fix-row-cutoff
branch
from
e0957cd
to
aa5a89a
Compare
zebp
force-pushed
the
zeb/fix-row-cutoff
branch
from
aa5a89a
to
47d5833
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1565 +/- ##
==========================================
- Coverage 41.47% 41.45% -0.02%
==========================================
Files 114 114
Lines 17838 17840 +2
==========================================
- Hits 7398 7396 -2
- Misses 10440 10444 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new average CPU row there's a bug where the widget wouldn't fix the height accordingly if the average gauge wasn't already on a new line, causing cores on any system core count isn't divisible by 4 to be cut off.
This is a screenshot of my 14c Macbook Pro having cores cut off before the fix.
And here's after the fix on a 16c32t system and the same 14c mac
Testing
Tested by enabling
average_cpu_rowon a system where the core count wasn't divisible by 4 to the UI bug was fixed and by doing the same on a system where the core count is divisible by 4 to ensure there's no breakage.Checklist
cargo fmt)README.md, help menu, doc pages, etc.)