Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename flags.enable_gpu to flags.disable_gpu (false by default) #1559

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

shurizzle
Copy link
Contributor

@shurizzle shurizzle commented Aug 13, 2024

Description

Rename flags.enable_gpu to flags.disable_gpu and make it false by default

Closes: #1554

@shurizzle shurizzle force-pushed the master branch 2 times, most recently from ab7135a to 9c4b973 Compare August 13, 2024 22:17
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.46%. Comparing base (1f011bd) to head (241c518).
Report is 1 commits behind head on main.

Files Patch % Lines
src/options/args.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1559      +/-   ##
==========================================
+ Coverage   41.39%   41.46%   +0.07%     
==========================================
  Files         114      114              
  Lines       17839    17837       -2     
==========================================
+ Hits         7385     7397      +12     
+ Misses      10454    10440      -14     
Flag Coverage Δ
macos-12 36.72% <88.88%> (+0.01%) ⬆️
ubuntu-latest 43.44% <88.88%> (+0.07%) ⬆️
windows-2019 36.92% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise looks fine.

Note I'll probably change it in the future to have more fine-grained control over what parts to include GPU info, but this is fine for now.

src/options.rs Outdated Show resolved Hide resolved
@shurizzle shurizzle force-pushed the master branch 2 times, most recently from 2ce65ac to 3481ff8 Compare August 14, 2024 03:10
@shurizzle shurizzle changed the title fix: enable flags.enable_gpu by default refactor: rename flags.enable_gpu to flags.disable_gpu (false by default) Aug 14, 2024
@shurizzle
Copy link
Contributor Author

I wanted to fix the documentation as well, but I would have asked you a ton of questions, so it might be faster if you fix it yourself. If there's anything wrong, just let me know.

Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. Thanks!

@ClementTsang
Copy link
Owner

@all-contributors please add @shurizzle for code.

Copy link
Contributor

@ClementTsang

@shurizzle already contributed before to code

@ClementTsang ClementTsang merged commit 6b0a285 into ClementTsang:main Aug 14, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No GPU temps (Nvidia) after updating to 0.10
2 participants