Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up some config and panic code #1556

Merged
merged 2 commits into from
Aug 11, 2024
Merged

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 11, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 91.37931% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.40%. Comparing base (96ed26d) to head (e9d4183).

Files Patch % Lines
src/main.rs 80.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1556      +/-   ##
==========================================
- Coverage   41.41%   41.40%   -0.02%     
==========================================
  Files         113      114       +1     
  Lines       17837    17847      +10     
==========================================
+ Hits         7387     7389       +2     
- Misses      10450    10458       +8     
Flag Coverage Δ
macos-12 36.73% <8.62%> (-0.08%) ⬇️
ubuntu-latest 43.37% <91.37%> (-0.02%) ⬇️
windows-2019 36.93% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang marked this pull request as ready for review August 11, 2024 06:04
@ClementTsang ClementTsang merged commit c65121c into main Aug 11, 2024
36 checks passed
@ClementTsang ClementTsang deleted the cleanup_2024-08-10 branch August 11, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant