Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: add test to validate default config, fix typo in default config #1552

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Aug 8, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Adds an additional test to ensure that the default config is valid TOML, as well as actually catch a typo in the default config.

This also adds scaffolding to check if it matches the default config, but currently the way we do that internally is a bit of a hack so I didn't actually enable the assert (as it fails). I'll handle that in another PR as I refactor some things like the internal layout.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang enabled auto-merge (squash) August 8, 2024 01:30
@ClementTsang ClementTsang changed the title other: add test to make sure default config is valid other: add test to make sure default config is valid and fix default config typo Aug 8, 2024
@ClementTsang ClementTsang changed the title other: add test to make sure default config is valid and fix default config typo other: add test to validate default config, fix typo in default config Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.27%. Comparing base (4c83672) to head (3b969b2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1552      +/-   ##
==========================================
+ Coverage   41.20%   43.27%   +2.07%     
==========================================
  Files         113       99      -14     
  Lines       17808    16962     -846     
==========================================
+ Hits         7338     7341       +3     
+ Misses      10470     9621     -849     
Flag Coverage Δ
macos-12 ?
ubuntu-latest 43.27% <100.00%> (+0.10%) ⬆️
windows-2019 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit cf47cb9 into main Aug 8, 2024
27 of 34 checks passed
@ClementTsang ClementTsang deleted the catch_broken_default_config branch August 8, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant