Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove time as a dependency outside of logging #1506

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jul 26, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

#1500 made me realize I actually don't really need to pull in time as a root dependency anymore; I was mostly just using it for local log debugging and just to avoid converting seconds to h/m/s.

This PR makes it so we are only using it for local log debugging.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang enabled auto-merge (squash) July 26, 2024 05:03
@ClementTsang ClementTsang enabled auto-merge (squash) July 26, 2024 05:04
@ClementTsang ClementTsang enabled auto-merge (squash) July 26, 2024 05:04
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.91%. Comparing base (c2d3ab5) to head (56b9163).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1506      +/-   ##
==========================================
+ Coverage   40.63%   40.91%   +0.28%     
==========================================
  Files         103      103              
  Lines       17554    17570      +16     
==========================================
+ Hits         7133     7189      +56     
+ Misses      10421    10381      -40     
Flag Coverage Δ
macos-12 36.28% <100.00%> (+0.30%) ⬆️
ubuntu-latest 42.89% <100.00%> (+0.29%) ⬆️
windows-2019 36.45% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang enabled auto-merge (squash) July 26, 2024 05:08
@ClementTsang ClementTsang merged commit 1208c45 into main Jul 26, 2024
36 checks passed
@ClementTsang ClementTsang deleted the remove_time branch July 26, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant