Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up conversion and crossterm errors #1493

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jul 14, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

This knocks out CrosstermError (which wasn't used) and ConversionError.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang enabled auto-merge (squash) July 14, 2024 07:57
Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.84%. Comparing base (571a801) to head (098986b).

Files Patch % Lines
src/data_collection/processes/unix/user_table.rs 0.00% 3 Missing ⚠️
src/data_collection/temperature/linux.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
+ Coverage   40.82%   40.84%   +0.02%     
==========================================
  Files         102      102              
  Lines       17632    17622      -10     
==========================================
  Hits         7198     7198              
+ Misses      10434    10424      -10     
Flag Coverage Δ
macos-12 36.22% <0.00%> (+0.01%) ⬆️
ubuntu-latest 42.79% <0.00%> (+0.02%) ⬆️
windows-2019 36.36% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit d97d75f into main Jul 14, 2024
34 checks passed
@ClementTsang ClementTsang deleted the error_refactor_pt_2 branch July 14, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant