Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add way to automatically generate new json schemas #1482

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Jun 16, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Uses schemars to automatically generate them as needed. Ideally we do this with a build script but I don't see an easy way of doing it. We can probably at least automate/enforce doing this with CI though.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Jun 16, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.

Project coverage is 53.64%. Comparing base (982b718) to head (2db0806).

Files Patch % Lines
src/main.rs 23.52% 13 Missing ⚠️
src/options/args.rs 0.00% 1 Missing ⚠️
src/options/config/cpu.rs 0.00% 1 Missing ⚠️
src/options/config/ignore_list.rs 0.00% 1 Missing ⚠️
src/options/config/process.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1482       +/-   ##
===========================================
+ Coverage   40.83%   53.64%   +12.80%     
===========================================
  Files         102      102               
  Lines       17525    17547       +22     
===========================================
+ Hits         7157     9413     +2256     
+ Misses      10368     8134     -2234     
Flag Coverage Δ
macos-12 36.19% <22.72%> (-0.02%) ⬇️
ubuntu-latest 56.25% <22.72%> (+13.45%) ⬆️
windows-2019 36.33% <22.72%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit 7666a09 into main Jun 16, 2024
36 checks passed
@ClementTsang ClementTsang deleted the schemars_auto branch June 16, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant