Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: fix -V not working and causing Cirrus CI to fail #1478

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

ClementTsang
Copy link
Owner

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

I used the wrong flag casing (-V vs -v) which broke Cirrus CI, which expected to run btm -V as a sanity check.

This fixes it and adds a test to catch it in the future.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.74%. Comparing base (ee2e1fe) to head (e91a0f2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
+ Coverage   40.94%   41.74%   +0.80%     
==========================================
  Files          99       96       -3     
  Lines       17462    17112     -350     
==========================================
- Hits         7149     7143       -6     
+ Misses      10313     9969     -344     
Flag Coverage Δ
macos-12 36.32% <ø> (ø)
ubuntu-latest 42.90% <ø> (+0.01%) ⬆️
windows-2019 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClementTsang ClementTsang merged commit 7aa379a into main Jun 5, 2024
37 checks passed
@ClementTsang ClementTsang deleted the fix_V_issue branch June 5, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant