-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove lib
and move some things around
#1477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1477 +/- ##
==========================================
+ Coverage 40.95% 40.97% +0.01%
==========================================
Files 99 99
Lines 17462 17459 -3
==========================================
+ Hits 7152 7153 +1
+ Misses 10310 10306 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ClementTsang
force-pushed
the
separate_bin_and_lib
branch
2 times, most recently
from
June 5, 2024 05:11
ebcee16
to
8989aa4
Compare
ClementTsang
force-pushed
the
separate_bin_and_lib
branch
from
June 5, 2024 05:12
8989aa4
to
c88e9a0
Compare
ClementTsang
force-pushed
the
separate_bin_and_lib
branch
from
June 5, 2024 05:21
c88e9a0
to
5cbe1fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:
A loooooong time ago (wow, it's been 4 years apparently...), I made the brilliant (/s) decision to use both
lib.rs
andmain.rs
because I was trying to add tests in thetests
folder that needed private access to some functions in thesrc
- and at the time, the only way I could think of doing so was exposing bottom as a library and a binary.This isn't necessarily bad, but for my use case, it's pretty unnecessary nowadays (since I've moved all my tests back into the source files) and adds complexity in looking for certain things, so it's high time we move things around and remove
lib.rs
. I also took the time to clean up some weird code I spotted along the way.Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
If this is a code change, please also indicate which platforms were tested:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, doc pages, etc.)