Battery table_gap patch #1458
Merged
Battery table_gap patch #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementTsang
approved these changes
May 3, 2024
|
Also tested on linux, works fine there. |
|
@all-contributors please add @TheSkyentist for code. |
|
I've put up a pull request to add @TheSkyentist! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the behavior of the battery widget when paired with the
skip_table_gap.Issue
Closes: #1457
Testing
Tested with and without the
skip_table_gapargument, both times works as expected. I only have access to a macOS laptop so I cannot test on Windows or Linux. I'm not proficient in Rust, so I'm open to feedback.Checklist
If relevant, ensure the following have been met:
cargo fmt)