Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: try attestations for binaries #1455

Merged
merged 2 commits into from
May 3, 2024
Merged

ci: try attestations for binaries #1455

merged 2 commits into from
May 3, 2024

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented May 2, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Seems like we've got a fun new feature to work with for validating builds, and it seems easy to integrate: https://docs.github.com/en/actions/security-guides/using-artifact-attestations-to-establish-provenance-for-builds

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang marked this pull request as ready for review May 3, 2024 05:45
@ClementTsang ClementTsang merged commit d53725b into main May 3, 2024
42 checks passed
@ClementTsang ClementTsang deleted the attestation_test branch May 3, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant