Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set a position of legend #1430

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

lyuha
Copy link
Contributor

@lyuha lyuha commented Mar 21, 2024

Description

Add options and args to change a position of time_chart's legend.

image

Issue

Related issues: #1125

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 71.11111% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 55.90%. Comparing base (2ee0df1) to head (6b76883).

Files Patch % Lines
src/options.rs 58.82% 14 Missing ⚠️
src/canvas/components/tui_widget/time_chart.rs 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
+ Coverage   55.84%   55.90%   +0.05%     
==========================================
  Files          97       97              
  Lines       18183    18271      +88     
==========================================
+ Hits        10154    10214      +60     
- Misses       8029     8057      +28     
Flag Coverage Δ
macos-12 39.29% <66.66%> (+0.13%) ⬆️
ubuntu-latest 58.49% <71.11%> (+0.04%) ⬆️
windows-2019 39.47% <66.66%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lyuha lyuha marked this pull request as ready for review March 25, 2024 09:21
@ClementTsang ClementTsang self-assigned this Mar 25, 2024
Copy link
Owner

@ClementTsang ClementTsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long - generally looks fine, left some small things to change/look at but otherwise should be good. Thanks for the PR!

docs/content/configuration/command-line-options.md Outdated Show resolved Hide resolved
src/options.rs Outdated Show resolved Hide resolved
src/options.rs Outdated Show resolved Hide resolved
@lyuha lyuha force-pushed the main branch 2 times, most recently from fb4d315 to 2f9d17b Compare March 30, 2024 14:57
@lyuha
Copy link
Contributor Author

lyuha commented Mar 30, 2024

I apply suggentions and rebase to one commit.

@lyuha
Copy link
Contributor Author

lyuha commented Apr 2, 2024

Could you rerun CI? I don't know why CI failed on macOS tests.

@ClementTsang
Copy link
Owner

Seems like it timed out for some reason.

Also sorry for the delay, I'll take a look at the changes in a bit.

@ClementTsang
Copy link
Owner

Made some small changes but otherwise looks good - thanks again for doing this!

@all-contributors please add @lyuha for code, docs

Copy link
Contributor

@ClementTsang

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @lyuha! 🎉

@ClementTsang ClementTsang merged commit a083ec0 into ClementTsang:main Apr 2, 2024
36 checks passed
ClementTsang added a commit that referenced this pull request Apr 2, 2024
ClementTsang added a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants