Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump cargo-deb version to 2.1.0 #1424

Merged
merged 1 commit into from
Mar 9, 2024
Merged

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Mar 9, 2024

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

The ARM versions are going to be handled by updating the images (see ClementTsang/cargo-deb-arm#15).

Of note, technical breaking change as per the upstream cargo-deb repo:

Note Since v2.0.0 the deb package version will have a "-1" suffix. You can disable this by adding --deb-revision="" flag or revision = "" in Cargo metadata. The default suffix is for compliance with Debian's packaging standard.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

Mock nightly build: https://github.com/ClementTsang/bottom/actions/runs/8216472368

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@ClementTsang ClementTsang merged commit 32e0477 into main Mar 9, 2024
42 checks passed
@ClementTsang ClementTsang deleted the bump-cargo-deb-2.1.0 branch March 9, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant