Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: use f32 for process percentage values #1212

Merged
merged 2 commits into from
Jun 18, 2023

Conversation

ClementTsang
Copy link
Owner

This cuts down memory by a tiny bit, and we don't need a full f64 for percentage values.

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

If this is a code change, please also indicate which platforms were tested:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Patch coverage: 6.66% and project coverage change: -0.02 ⚠️

Comparison is base (9cd953e) 31.61% compared to head (a3c6982) 31.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
- Coverage   31.61%   31.59%   -0.02%     
==========================================
  Files          97       97              
  Lines       16502    16510       +8     
==========================================
  Hits         5217     5217              
- Misses      11285    11293       +8     
Flag Coverage Δ
macos-12 33.17% <12.50%> (-0.02%) ⬇️
ubuntu-latest 33.17% <7.14%> (-0.02%) ⬇️
windows-2019 33.42% <14.28%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/data_harvester/processes.rs 0.00% <ø> (ø)
src/app/data_harvester/processes/linux.rs 16.72% <0.00%> (-0.18%) ⬇️
...c/app/data_harvester/processes/unix/process_ext.rs 0.00% <0.00%> (ø)
src/app/data_harvester/processes/windows.rs 0.00% <ø> (ø)
src/app/frozen_state.rs 15.78% <ø> (ø)
src/app/query.rs 0.00% <0.00%> (ø)
src/widgets/process_table/proc_widget_data.rs 36.32% <ø> (ø)
src/clap.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This cuts down memory by a tiny bit, and we don't need a full f64 for
percentage values.
@ClementTsang ClementTsang merged commit 7c0eda1 into master Jun 18, 2023
33 checks passed
@ClementTsang ClementTsang deleted the use_f32_for_process_percents branch June 18, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant