bug: fix using 'none' for legend position in configs

ClementTsang · Sep 12, 2024 · 2f8aec7 · 2f8aec7
1 parent eaa5623
commit 2f8aec7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/canvas/components/tui_widget/time_chart.rs b/src/canvas/components/tui_widget/time_chart.rs
@@ -223,7 +223,7 @@ impl FromStr for LegendPosition {
     type Err = ParseLegendPositionError;
 
     fn from_str(s: &str) -> Result<Self, Self::Err> {
-        match s.to_ascii_lowercase().as_str() {
+        match s {
             "top" => Ok(Self::Top),
             "top-left" => Ok(Self::TopLeft),
             "top-right" => Ok(Self::TopRight),

diff --git a/src/options.rs b/src/options.rs
@@ -960,8 +960,11 @@ fn get_network_legend_position(
             position => Some(parse_config_value!(position.parse(), "network_legend")?),
         }
     } else if let Some(flags) = &config.flags {
-        if let Some(legend) = &flags.network_legend {
-            Some(parse_arg_value!(legend.parse(), "network_legend")?)
+        if let Some(s) = &flags.network_legend {
+            match s.to_ascii_lowercase().trim() {
+                "none" => None,
+                position => Some(parse_arg_value!(position.parse(), "network_legend")?),
+            }
         } else {
             Some(LegendPosition::default())
         }