Adapt VQE- Paper Implementation Challenge #899
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Hi @Dacastillo , it is unclear what this PR is for. You added two notebooks, that seem very similar to ones we already have. In addition, you added some qiskit-nature code. I do not see how this PR addresses issue for Adaptive VQE. I am not sure how the approach of We can extend the deadline, how much time do you think you need to complete your contribution? |
|
Dear Tomer:
This code is clearly not a complete result. We are working on having a code that satisfies the project. The notebook we put are the basis we are using to understand the Classiq code and translating the Qiskit-Nature made code to something the Classiq system can work in. I talked with Tali Cohn and we received a new deadline (until this Sunday) to make the implementation visible for you. We will make all for respecting this new date.
Any advice you can give us for the translation will be helpful. We can doing all the queries needen on the Slack channel.
Greetings.
…________________________________
De: TomerGoldfriend ***@***.***>
Enviado: martes, 1 de abril de 2025 5:09
Para: Classiq/classiq-library ***@***.***>
Cc: Daniel Andres Castillo Castro ***@***.***>; Mention ***@***.***>
Asunto: Re: [Classiq/classiq-library] Adapt VQE- Paper Implementation Challenge (PR #899)
No suele recibir correo electrónico de ***@***.*** Por qué es esto importante<https://aka.ms/LearnAboutSenderIdentification>
Hi @Dacastillo<https://github.com/Dacastillo> , it is unclear what this PR is for. You added two notebooks, that seem very similar to ones we already have. In addition, you added some qiskit-nature code. I do not see how this PR addresses issue<#798> for Adaptive VQE.
I am not sure how the approach of flexible_qpe is relevant here. Feel free to reach out to the community on Slack if you have questions.
We can extend the deadline, how much time do you think you need to complete your contribution?
—
Reply to this email directly, view it on GitHub<#899 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABVDV34BA6BXVXK4CS74VD32XJCUXAVCNFSM6AAAAABZ6N7DOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRYGUZTQOJTGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[TomerGoldfriend]TomerGoldfriend left a comment (Classiq/classiq-library#899)<#899 (comment)>
Hi @Dacastillo<https://github.com/Dacastillo> , it is unclear what this PR is for. You added two notebooks, that seem very similar to ones we already have. In addition, you added some qiskit-nature code. I do not see how this PR addresses issue<#798> for Adaptive VQE.
I am not sure how the approach of flexible_qpe is relevant here. Feel free to reach out to the community on Slack if you have questions.
We can extend the deadline, how much time do you think you need to complete your contribution?
—
Reply to this email directly, view it on GitHub<#899 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABVDV34BA6BXVXK4CS74VD32XJCUXAVCNFSM6AAAAABZ6N7DOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONRYGUZTQOJTGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Adding a new version with new code. We are making checks and cleaning to give an adequate implementation result this Saturday. |
@Dacastillo is it ready for review? |
|
@Dacastillo Are you still working on this? |
Yes, I am. I am finished a prototype notebook. I am struggling with the testing part, making a good enough test file. |
This pull request is related with this project: #798. Here it is the ideas we have:
We require some time to complete the code combination and test at least with the 3 examples mentioned before. It will be made more changes in this request.