This repository has been archived by the owner on Apr 13, 2024. It is now read-only.
enable clang's integrated assembler for arm64 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this actually work with |
|
oh! good point! (I should verify locally w/o aarch64-linux-gnu-as) |
10 tasks
|
For the record, this now works as expected after the patch that resolves ClangBuiltLinux/linux#577. Still will fair because of ClangBuiltLinux/linux#473. |
tpimh
reviewed
Oct 2, 2019
| @@ -191,6 +191,12 @@ check_dependencies() { | |||
| fi | |||
| check_objcopy_version | |||
| ${OBJCOPY} --version | |||
|
|
|||
| if [[ -z "${AS:-}" ]]; then | |||
| for AS in clang-9 "${CROSS_COMPILE:-}"as; do | |||
There was a problem hiding this comment.
This always prefers clang as AS unless AS environment variable specified.
There are two ways to change it:
- Change
ASdefinition in similar fashion withLD(preferred) - Basically invert
ASvariable in travis environment: for every job which specifiesASremove the variable, for every job without this variable add it with value set to appropriateasname for cross-compilation
Anyway this wouldn't work at all because the variable isn't passed to make. I fixed it here: 1a2921f#diff-edd6bdbc5716dde5e06b45ae44b43caaR313
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.