Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contrib-first.md #1467

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Update contrib-first.md #1467

merged 3 commits into from
Nov 14, 2024

Conversation

mgifford
Copy link
Contributor

@mgifford mgifford commented Nov 14, 2024 •
edited by github-actions bot
Loading

Adding DPGs

📚 Documentation preview 📚: https://civicactions-handbook--1467.org.readthedocs.build/en/1467/

@mgifford mgifford requested a review from swirtSJW November 14, 2024 14:29
@mgifford mgifford requested a review from a team as a code owner November 14, 2024 14:29
swirtSJW
swirtSJW reviewed Nov 14, 2024
View reviewed changes
Copy link
Member

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that one line related to the suggested change, this looks great @mgifford

common-practices-tools/contribution/contrib-first.md Outdated Show resolved Hide resolved
@mgifford @swirtSJW
Update common-practices-tools/contribution/contrib-first.md
2262b11 
That's better. Thanks.

Co-authored-by: Steve Wirt <[email protected]>
@mgifford mgifford requested a review from dmundra November 14, 2024 16:54
@swirtSJW swirtSJW merged commit c551607 into master Nov 14, 2024
13 checks passed
@swirtSJW swirtSJW deleted the mgifford-patch-1 branch November 14, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swirtSJW swirtSJW swirtSJW approved these changes

@dmundra dmundra Awaiting requested review from dmundra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgifford @swirtSJW