Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mural & tiny side quests #1390

Merged
merged 23 commits into from
Jun 18, 2024
Merged

Mural & tiny side quests #1390

merged 23 commits into from
Jun 18, 2024

Conversation

TheBoatyMcBoatFace
Copy link
Member

@TheBoatyMcBoatFace TheBoatyMcBoatFace commented Jun 13, 2024

Primarily added Mural documentation, but also updated the main README and added some stuff to .gitignore


📚 Documentation preview 📚: https://civicactions-handbook--1390.org.readthedocs.build/en/1390/

Make the URL prettier

Signed-off-by: TheBoatyMcBoatFace <[email protected]>
1) Created a page for Mural in tools & support
2) Added a screenshot of where to find mural rooms
3) Added Mural to the dropdown menu

Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Nova config is handled in the .nova directory. While this is clearly the best code editor out there, not everyone uses it. Until Nova takes over the MacWorld, I’m adding the .nova directory to the ignores

Signed-off-by: TheBoatyMcBoatFace <[email protected]>
@TheBoatyMcBoatFace TheBoatyMcBoatFace requested review from a team as code owners June 13, 2024 16:19
@dmundra
Copy link
Collaborator

dmundra commented Jun 13, 2024

Looking good. In #1388 I fix the "unexpected spaces" issues, can you review that one and approve it.

@dmundra
Copy link
Collaborator

dmundra commented Jun 13, 2024

Ya so prettier is moving the spaces (via pre-commit) for list indents and then remark is flagging it as a problem.

@dmundra
Copy link
Collaborator

dmundra commented Jun 13, 2024

Thanks for merging #1388 @TheBoatyMcBoatFace. If you update this one now with master it should clean up the indent list spaces complaint.

@TheBoatyMcBoatFace
Copy link
Member Author

Agh - that is SUPER FRUSTRATING. Fixing now.

@dmundra
Copy link
Collaborator

dmundra commented Jun 13, 2024

Agh - that is SUPER FRUSTRATING. Fixing now.

Sorry about that. You shouldn't need to change anything just, rebase either locally or with the 'Update branch' button.

@TheBoatyMcBoatFace
Copy link
Member Author

Oh this is on me. I’ve let a few repos get out of date and didn’t document the different git standards for each like I used to. It looks like only the pre-commit was fixed, just some problem on Line 48 now.

Copy link
Collaborator

@dmundra dmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheBoatyMcBoatFace the list indent issue should be fixed (see Files changed tab). I left you comments on some other changes.

common-practices-tools/software-and-support/mural.md Outdated Show resolved Hide resolved
common-practices-tools/software-and-support/mural.md Outdated Show resolved Hide resolved
@dmundra
Copy link
Collaborator

dmundra commented Jun 13, 2024

@TheBoatyMcBoatFace pre-commit is going to keep putting back the list item indent spaces so I would not fight that. I just wanted to merge #1388 so it doesn't flag it as a problem.

pre-commit-ci bot and others added 2 commits June 13, 2024 17:36
Pre-commit HATES Slack channels, specifically when you `\#` to show the `#` sign. I just renamed the buttons and links so they can play nice with pre-commit, my arch-nemesis.

Signed-off-by: TheBoatyMcBoatFace <[email protected]>
@TheBoatyMcBoatFace
Copy link
Member Author

@dmundra 0a1f83a should resolve everything. The previous commit technically passes the tests, but pre-commit removes the \ before # when you need to use # in buttons, text, etc... I just removed the #, but we can add a rule to ignore those types of auto-replacements if it becomes an issue with future revisions.

I haven't been humbled by a pull request in a while. Pre-commit humbled me today.

Copy link
Collaborator

@dmundra dmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheBoatyMcBoatFace for fighting the good fight.

@dmundra dmundra enabled auto-merge (squash) June 18, 2024 02:07
@dmundra dmundra merged commit b0aac6a into master Jun 18, 2024
11 checks passed
@dmundra dmundra deleted the TheBoatyMcBoatFace-patch-1 branch June 18, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants