-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mural & tiny side quests #1390
Mural & tiny side quests #1390
Conversation
Make the URL prettier Signed-off-by: TheBoatyMcBoatFace <[email protected]>
1) Created a page for Mural in tools & support 2) Added a screenshot of where to find mural rooms 3) Added Mural to the dropdown menu Signed-off-by: TheBoatyMcBoatFace <[email protected]>
Nova config is handled in the .nova directory. While this is clearly the best code editor out there, not everyone uses it. Until Nova takes over the MacWorld, I’m adding the .nova directory to the ignores Signed-off-by: TheBoatyMcBoatFace <[email protected]>
for more information, see https://pre-commit.ci
Looking good. In #1388 I fix the "unexpected spaces" issues, can you review that one and approve it. |
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
for more information, see https://pre-commit.ci
Ya so prettier is moving the spaces (via pre-commit) for list indents and then remark is flagging it as a problem. |
Thanks for merging #1388 @TheBoatyMcBoatFace. If you update this one now with master it should clean up the indent list spaces complaint. |
Agh - that is SUPER FRUSTRATING. Fixing now. |
Sorry about that. You shouldn't need to change anything just, rebase either locally or with the 'Update branch' button. |
…to TheBoatyMcBoatFace-patch-1
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
for more information, see https://pre-commit.ci
Oh this is on me. I’ve let a few repos get out of date and didn’t document the different git standards for each like I used to. It looks like only the pre-commit was fixed, just some problem on Line 48 now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheBoatyMcBoatFace the list indent issue should be fixed (see Files changed tab). I left you comments on some other changes.
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
…Actions/guidebook into TheBoatyMcBoatFace-patch-1
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
for more information, see https://pre-commit.ci
Resolves: #1390 (comment) Signed-off-by: TheBoatyMcBoatFace <[email protected]>
@TheBoatyMcBoatFace pre-commit is going to keep putting back the list item indent spaces so I would not fight that. I just wanted to merge #1388 so it doesn't flag it as a problem. |
for more information, see https://pre-commit.ci
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
…Actions/guidebook into TheBoatyMcBoatFace-patch-1
Signed-off-by: TheBoatyMcBoatFace <[email protected]>
for more information, see https://pre-commit.ci
Pre-commit HATES Slack channels, specifically when you `\#` to show the `#` sign. I just renamed the buttons and links so they can play nice with pre-commit, my arch-nemesis. Signed-off-by: TheBoatyMcBoatFace <[email protected]>
@dmundra 0a1f83a should resolve everything. The previous commit technically passes the tests, but pre-commit removes the I haven't been humbled by a pull request in a while. Pre-commit humbled me today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TheBoatyMcBoatFace for fighting the good fight.
Primarily added Mural documentation, but also updated the main README and added some stuff to .gitignore
📚 Documentation preview 📚: https://civicactions-handbook--1390.org.readthedocs.build/en/1390/