-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
812 eoy table #818
base: master
Are you sure you want to change the base?
812 eoy table #818
Conversation
def yearly_task(): | ||
"""Task group to create yearly tables and triggers.""" | ||
bt_replace_trigger = PythonOperator( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to taskflow-ify this one! 🤔
As discussed, here is the template I've used within the ETL DAGs which uses generic short circuit operators short circuit operators to check the date. |
|
||
return task_msg | ||
bt_bot = PostgresHook('bt_bot') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can go inside bt_replace_trigger
once you taskflow that one.
I think the new @task.run_if decorator in 2.10 will be helpful for simplifying EOY/EOM tasks. Something like |
What this pull request accomplishes:
Issue(s) this solves:
What, in particular, needs to reviewed:
What needs to be done by a sysadmin after this PR is merged
git pull to data_script