HP-2491 | return kc_action_status from Keycloak on authentication #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #314 +/- ##
===========================================
+ Coverage 80.36% 80.44% +0.07%
===========================================
Files 91 91
Lines 3789 3804 +15
===========================================
+ Hits 3045 3060 +15
Misses 744 744 ☔ View full report in Codecov by Sentry. |
danipran
reviewed
Aug 7, 2024
charn
force-pushed
the
HP-2491-kc-action-status
branch
2 times, most recently
from
6f2779f
to
6b784c9
Compare
charn
force-pushed
the
HP-2491-kc-action-status
branch
from
6b784c9
to
0ca21fe
Compare
kc_action_status is used to indicate e.g. whether a requested password change was successful or not. It will be returned from tunnistamo along with code and state to the callback url the same way keycloak does it. This should make a later transtition to keycloak (by dropping tunnistamo from the middle) not require extra work for any logic using kc_action_status. Upon login the kc_action_status is saved to the session from which it is then retrieved in TunnistamoAuthorizeEndpoint. Refs: HP-2491
charn
force-pushed
the
HP-2491-kc-action-status
branch
from
0ca21fe
to
f26f601
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kc_action_statusis used to indicate e.g. whether a requested password change was successful or not. It will be returnedfrom tunnistamo along with
codeandstateto the callback url the same way keycloak does it. This should make a latertranstition to keycloak (by dropping tunnistamo from the middle) not require extra work for any logic using
kc_action_status.Upon login the
kc_action_statusis saved to the session from which it is then retrieved inTunnistamoAuthorizeEndpoint.