HP-2461 | feat: pass keycloak action parameter through #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #313 +/- ##
===========================================
+ Coverage 80.35% 80.36% +0.01%
===========================================
Files 91 91
Lines 3787 3789 +2
===========================================
+ Hits 3043 3045 +2
Misses 744 744 ☔ View full report in Codecov by Sentry. |
nicobav
requested changes
Jul 3, 2024
Running actions with keycloak is done using `kc_action` parameter. Here, we're just passing the action through so that a user can e.g. update the password on keycloak while the authentication still flows through tunnistamo. Also add some walrus-operators to if-statements. Refs: HP-2461
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running actions with keycloak is done using
kc_actionparameter. Here, we're just passing the action through so that a user can e.g. update the password on keycloak while the authentication still flows through tunnistamo.