-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HP-2441 | deps: bump to django 4.2 #312
Conversation
9606712
to
ba03e1a
Compare
9d7674d
to
7766b85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #312 +/- ##
===========================================
+ Coverage 80.44% 80.48% +0.04%
===========================================
Files 91 91
Lines 3804 3843 +39
===========================================
+ Hits 3060 3093 +33
- Misses 744 750 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 left one suggestion.
9238e25
to
22268a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Using get_random_string without parameters is deprecated. Use the old django default value of 12. Refs: HP-2441
There were significant changes in logout actions so those were the tricky parts to handle. - Other dependencies are bumped also where applicable. - bump psycopg to v3 - Bump development depencies - Bump uwsgi - fixes migration for fresh environments - Bump local docker postgres to 13.4 which is used in production Data migration users.0022 uses a signal to set the data correctly. To make the migration pass an old version of the model model is given signal function, which makes the migration pass for any fresh tunnistamo environment. Refs HP-2441
Previously logging out from suomi.fi was in TunnistamoOidcEndSessionView now introducing new suomi.fi end session view for logging out suomi.fi in django 4.2 Refs HP-2441
Refs: HP-2441
Fixes the following warning: - WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match Refs: HP-2441
Refs: HP-2441
Please change apiscopetranslation.master to a parler.fields.TranslationsForeignKey field to support translations in data migrations. Refs: HP-2441
Quality Gate failedFailed conditions |
No description provided.