Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP-2441 | deps: bump to django 4.2 #312

Merged
merged 10 commits into from
Sep 16, 2024
Merged

HP-2441 | deps: bump to django 4.2 #312

merged 10 commits into from
Sep 16, 2024

Conversation

nicobav
Copy link
Contributor

@nicobav nicobav commented Jul 2, 2024

No description provided.

@nicobav nicobav force-pushed the django-42 branch 4 times, most recently from 9606712 to ba03e1a Compare July 4, 2024 14:00
@nicobav nicobav force-pushed the django-42 branch 5 times, most recently from 9d7674d to 7766b85 Compare July 11, 2024 16:51
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (72d0cbf) to head (1095460).
Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
users/views.py 90.62% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #312      +/-   ##
===========================================
+ Coverage    80.44%   80.48%   +0.04%     
===========================================
  Files           91       91              
  Lines         3804     3843      +39     
===========================================
+ Hits          3060     3093      +33     
- Misses         744      750       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicobav nicobav marked this pull request as ready for review July 12, 2024 06:15
@nicobav nicobav requested a review from a team July 12, 2024 06:15
danipran
danipran previously approved these changes Jul 12, 2024
Copy link

@danipran danipran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 left one suggestion.

auth_backends/tests/conftest.py Outdated Show resolved Hide resolved
@nicobav nicobav marked this pull request as draft July 12, 2024 13:27
@nicobav nicobav marked this pull request as ready for review July 12, 2024 13:44
@nicobav nicobav requested a review from danipran July 12, 2024 13:44
@charn charn changed the title deps: bump to django 4.2 HP-2441 | deps: bump to django 4.2 Jul 25, 2024
@charn charn force-pushed the django-42 branch 7 times, most recently from 9238e25 to 22268a4 Compare July 31, 2024 12:30
danipran
danipran previously approved these changes Aug 14, 2024
Copy link

@danipran danipran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

charn and others added 2 commits September 6, 2024 10:18
Using get_random_string without parameters is
deprecated. Use the old django default value of 12.

Refs: HP-2441
There were significant changes in logout actions so those were the
tricky parts to handle.

- Other dependencies are bumped also where applicable.
- bump psycopg to v3
- Bump development depencies
- Bump uwsgi
- fixes migration for fresh environments
- Bump local docker postgres to 13.4 which is used in production

Data migration users.0022 uses a signal to set the data correctly.
To make the migration pass an old version of the model model is
given signal function, which makes the migration pass for any fresh
tunnistamo environment.

Refs HP-2441
nicobav and others added 8 commits September 6, 2024 10:24
Previously logging out from suomi.fi was in TunnistamoOidcEndSessionView
now introducing new suomi.fi end session view for logging out suomi.fi
in django 4.2

Refs HP-2441
Fixes the following warning:
- WARN: FromAsCasing: 'as' and 'FROM' keywords' casing do not match

Refs: HP-2441
Please change apiscopetranslation.master to a
parler.fields.TranslationsForeignKey field to
support translations in data migrations.

Refs: HP-2441
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
58.6% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

@nicobav nicobav merged commit 33f51ca into develop Sep 16, 2024
4 of 5 checks passed
@nicobav nicobav deleted the django-42 branch September 16, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants