Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new "helsinki_tunnus" social auth backend #297

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

mikkokeskinen
Copy link
Contributor

The backend is a subclass of the existing HelsinkiTunnistus backend. The new backend is needed to add a second client (and login method) in Helsinki Tunnistus Keycloak for logging in with username and password.

Refs HP-2017

The backend is a subclass of the existing HelsinkiTunnistus backend. The
new backend is needed to add a second client (and login method) in
Helsinki Tunnistus Keycloak for logging in with username and password.
@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #297 (80eec91) into develop (033017f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #297      +/-   ##
===========================================
+ Coverage    80.24%   80.29%   +0.04%     
===========================================
  Files           90       91       +1     
  Lines         3766     3775       +9     
===========================================
+ Hits          3022     3031       +9     
  Misses         744      744              
Files Coverage Δ
auth_backends/helsinki_tunnus.py 100.00% <100.00%> (ø)
tunnistamo/settings.py 87.76% <100.00%> (+0.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mikkokeskinen mikkokeskinen merged commit 74615e2 into develop Sep 27, 2023
7 of 8 checks passed
@mikkokeskinen mikkokeskinen deleted the HP-2017-helsinki-tunnus-login-method branch September 27, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants