LINK-1529: Give a ValidationError for invalid image id #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harriris-vincit
force-pushed
the
fix/LINK-1529_image-id-500-error
branch
3 times, most recently
from
81afda9
to
b830434
Compare
|
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr988.api.dev.hel.ninja 🚀🚀🚀 |
|
Bunch of tests are failing - perhaps something to do still |
Refs: LINK-1529
harriris-vincit
force-pushed
the
fix/LINK-1529_image-id-500-error
branch
from
b830434
to
b242f42
Compare
|
|
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr988.api.dev.hel.ninja 🚀🚀🚀 |
@nicobav Fixed. Had used |
nicobav
approved these changes
Sep 20, 2024
nicobav
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Non-numeric event image IDs have resulted in a 500 internal server error. This PR implements a fix that makes the API return a
serializers.ValidationErrorinstead.Closes
LINK-1529