Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINK-2112: Check refund status from a new endpoint #983

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

harriris-vincit
Copy link
Contributor

@harriris-vincit harriris-vincit commented Sep 11, 2024

Description

Checks Talpa refund status from a new endpoint that is soon to be added to the Talpa Payment Exprerience API. This is needed for partial payment refunds as each refund will be their own instance with their own payment, and the older existing Talpa endpoint has supported fetching only the first refund's status (as partial refunds haven't actually been supported by Talpa before).

Closes

LINK-2112

@harriris-vincit harriris-vincit requested a review from a team September 11, 2024 11:37
@harriris-vincit harriris-vincit marked this pull request as ready for review September 11, 2024 11:37
@harriris-vincit harriris-vincit force-pushed the feature/LINK-2112_partial-refund-status-check branch from becd0b7 to 1ac07df Compare September 12, 2024 07:25
@terovirtanen
Copy link
Contributor

LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr983.api.dev.hel.ninja 🚀🚀🚀

registrations/utils.py Outdated Show resolved Hide resolved
@harriris-vincit harriris-vincit force-pushed the feature/LINK-2112_partial-refund-status-check branch from 1ac07df to 612f646 Compare September 13, 2024 07:51
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (bacec67) to head (612f646).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #983      +/-   ##
==========================================
+ Coverage   90.37%   90.60%   +0.23%     
==========================================
  Files         393      406      +13     
  Lines       37458    38823    +1365     
==========================================
+ Hits        33851    35177    +1326     
- Misses       3607     3646      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Sep 13, 2024

Copy link
Contributor

@tuomas777 tuomas777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 💸

@harriris-vincit harriris-vincit merged commit 77000ed into main Sep 13, 2024
15 of 17 checks passed
@harriris-vincit harriris-vincit deleted the feature/LINK-2112_partial-refund-status-check branch September 13, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants