-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Ruff #1005
Switch to Ruff #1005
Conversation
87ea40e
to
431b4f0
Compare
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1005.api.dev.hel.ninja 🚀🚀🚀 |
431b4f0
to
bb47a7a
Compare
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1005.api.dev.hel.ninja 🚀🚀🚀 |
bb47a7a
to
90f934d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1005 +/- ##
==========================================
+ Coverage 91.29% 91.32% +0.02%
==========================================
Files 405 405
Lines 38730 38711 -19
==========================================
- Hits 35357 35351 -6
+ Misses 3373 3360 -13 ☔ View full report in Codecov by Sentry. |
5a01f6c
to
3b487c9
Compare
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1005.api.dev.hel.ninja 🚀🚀🚀 |
3b487c9
to
0a16d94
Compare
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1005.api.dev.hel.ninja 🚀🚀🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a question about mccabe
a71cec5
to
6bcc31a
Compare
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1005.api.dev.hel.ninja 🚀🚀🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
a445a90
to
c9a2357
Compare
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1005.api.dev.hel.ninja 🚀🚀🚀 |
c9a2357
to
cf18641
Compare
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1005.api.dev.hel.ninja 🚀🚀🚀 |
cf18641
to
e93e4ca
Compare
Quality Gate passedIssues Measures |
LINKEDEVENTS-API branch is deployed to platta: https://linkedevents-pr1005.api.dev.hel.ninja 🚀🚀🚀 |
This PR introduces Ruff as the new linter and formatter, replacing the previously used tools: Black, Flake8, and isort. The goal is also to standardize the linting and formatting rules across all of our backend projects.
One key change to linting/formatting rules is the reduction of the linter maximum line length from 120 to 88 characters. Consequently, hundreds of lines exceeding the new limit are marked with
# noqa: E501
to prevent linting errors. These comments can be removed gradually as the codebase is updated to comply with the new standard.The PR includes a significant number of modified lines, primarily due to automatic formatting by Ruff. Reviewers can safely skip the following commits during manual review, as they involve safe automatic formatting:
Some automatic changes made by Ruff and autopep8 (which was run to help fix excessively long lines) may require some manual inspection, as they could be potentially unsafe:
After the review and before merging, the plan is to squash commits for a cleaner history, perhaps combining the current
chore
commits into one and thestyle
commits into another (which can then be added to.git-blame-ignore-revs
).Update: Added some new rules to Ruff lint config:
flake8-bugbear
(excluding opinionated rules 9xx) andpep8-naming
: these are in use with Flake8 in many of our projects, so let's keep using themflake8-print
andflake8-pie
: these are pretty trivial to addNew commits start from cc32264
Refs LINK-2201