Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About box improvements #8959

Merged
merged 15 commits into from
Oct 8, 2024
Merged

About box improvements #8959

merged 15 commits into from
Oct 8, 2024

Conversation

EdwinKato
Copy link
Contributor

@EdwinKato EdwinKato commented Sep 24, 2024 •
edited
Loading

Changelog

Added

  • Add tooltip in the back office explaining what is included in participant numbers
  • Allow admins to show or hide participation numbers in the about box from the content builder
  • Show participation avatars in the about box

@cl-dev-bot
Copy link
Collaborator

cl-dev-bot commented Sep 24, 2024 •
edited
Loading

Warnings
⚠️ The PR title contains no Jira issue key (case-sensitive)
⚠️ The branch name contains no Jira issue key (case-sensitive)
Messages
📖 Changelog provided 🎉
📖

Run the e2e tests
📖 Check translation progress

Generated by 🚫 dangerJS against 08e0f7b

@EdwinKato EdwinKato changed the title Add tooltip explaining participation numbers About box improvements Sep 25, 2024
amanda-anderson
amanda-anderson approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@amanda-anderson amanda-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! Just a couple small comments/questions. Happy to approve in advance :)

@EdwinKato EdwinKato merged commit 13c4582 into master Oct 8, 2024
15 checks passed
@EdwinKato EdwinKato deleted the add-tooltip-for-participation-info branch October 8, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanda-anderson amanda-anderson amanda-anderson approved these changes

Assignees
No one assigned
Labels
waiting for translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdwinKato @cl-dev-bot @amanda-anderson