-
-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triumph's Atmos Pipe Colours and Accident Prone Supermatter #6752
Open
washikarasu
wants to merge
16
commits into
Citadel-Station-13:master
Choose a base branch
from
washikarasu:triumph-engineering
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Triumph's Atmos Pipe Colours and Accident Prone Supermatter #6752
washikarasu
wants to merge
16
commits into
Citadel-Station-13:master
from
washikarasu:triumph-engineering
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
label
Sep 14, 2024
…nt think about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Changes the colour of Triumph's Atmospherics' pipes, hopefully for the better, matching it with Atlas', makes it so the supermatter engine won't melt it's containment even at a "cold" temperature removes some objects from inside walls.
Why It's Good For The Game
Making the pipe colouring matching makes it so it's not confusing when swapping maps, it's got me a couple of times. Making it so the Supermatter won't melt the walls is... pretty obvious, a fire will always pop up in the supermatter and there's a 2/9 chance it was next to a wall that could be destroyed by fire, now it's blast doors, it won't melt.
Changelog
Engine core touchups, removing the unused trash output console from the Supermatter Engine along with the bottlenecking pump, removed catwalks from inside port nacelle's walls, removed a wire from inside a wall, changed permissions along telecommunications and atmospherics storage so you can no longer waltz into engineering uninvited.
🆑
add: access helpers along triumph telecomms
del: triumph sme_engine trash pump
del: triumph sme_engine trash console
tweak: swapped the two reinforced walls in the triumph sme_engine and the door with blast doors
tweak: swapped some triumph maintenance access helpers with engineering ones along appropriate areas
/:cl: