Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX2.0] Adds Unified Policy Object Resource and Data Source #333

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

seconroy
Copy link
Collaborator

@seconroy seconroy commented Sep 13, 2024

Description

Adds Add the following resources and data sources:

  • Policy Object Unified Advanced Malware Protection
  • Policy Object Unified URL Filtering
  • Policy Object Unified TSL/SSL Profile
  • Policy Object Unified Intrusion Prevention
  • Policy Object Unified Advanced Inspection Profile
  • Policy Object Unified TSL/SSL Decryption
  • Policy Object Security Protocol List

Policy Object Unified TSL/SSL Decryption requires the Root CA to be configured.

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/CI change
  • Code quality improvement/refactoring/documentation (no functional changes)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests pass locally

@seconroy seconroy requested a review from tzarski0 October 3, 2024 10:14
Copy link
Collaborator

@tzarski0 tzarski0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of the comments included, we should also recheck which field should be marked as mandatory as I see in most objects we put everything as optional but in API in many cases those fields are mandatory.

@seconroy seconroy force-pushed the policy-objects-unified branch from 7fcff35 to ce4593b Compare November 20, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants