-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX2.0] Adds Unified Policy Object Resource and Data Source #333
Open
seconroy
wants to merge
15
commits into
CiscoDevNet:main
Choose a base branch
from
seconroy:policy-objects-unified
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarski0
requested changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On top of the comments included, we should also recheck which field should be marked as mandatory as I see in most objects we put everything as optional but in API in many cases those fields are mandatory.
gen/definitions/profile_parcels/policy_object_security_protocol_list.yaml
Outdated
Show resolved
Hide resolved
gen/definitions/profile_parcels/policy_object_unified_advanced_malware_protection.yaml
Show resolved
Hide resolved
gen/definitions/profile_parcels/policy_object_unified_advanced_malware_protection.yaml
Show resolved
Hide resolved
gen/definitions/profile_parcels/policy_object_unified_advanced_malware_protection.yaml
Show resolved
Hide resolved
gen/definitions/profile_parcels/policy_object_unified_advanced_malware_protection.yaml
Show resolved
Hide resolved
gen/definitions/profile_parcels/policy_object_unified_advanced_malware_protection.yaml
Show resolved
Hide resolved
gen/definitions/profile_parcels/policy_object_unified_intrusion_prevention.yaml
Outdated
Show resolved
Hide resolved
gen/definitions/profile_parcels/policy_object_unified_tls_ssl_decryption.yaml
Show resolved
Hide resolved
gen/definitions/profile_parcels/policy_object_unified_tls_ssl_decryption.yaml
Show resolved
Hide resolved
seconroy
force-pushed
the
policy-objects-unified
branch
from
November 20, 2024 09:20
7fcff35
to
ce4593b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Add the following resources and data sources:
Policy Object Unified TSL/SSL Decryption requires the Root CA to be configured.
Types of Changes
Checklist