Add BGP route redistribution object #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danischm
Couple of comments questions about this PR:
The attribute
protocol_instance
is used in thedn
. Thusid: True
. Forstatic
anddirect
protocols this should be set tonone
, I was expecting to use a default value, but default values do not work for attributes withid: True
. I decided then to put this information in the attribute descriptionterraform-provider-nxos/gen/definitions/bgp_route_redistribution.yaml
Line 72 in 22ea257
What about improving the logic of the
.tf
example to just considers the attributes with the keyexample
set ? For this particular resource I did not set theexample
key for the attributesrv6_prefix_type
. Nonetheless, it is still shown in the.tf
example. https://github.com/CiscoDevNet/terraform-provider-nxos/blob/jg-bgp-interleak/examples/resources/nxos_bgp_route_redistribution/resource.tf