Remove expiry date attributes from internal user resource

CiscoDevNet · Oct 10, 2023 · 928e636 · 928e636
1 parent 335577d
commit 928e636
Show file tree

Hide file tree

Showing 12 changed files with 18 additions and 77 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,7 +3,7 @@
 - Fix issue with reading nested conditions using `ise_network_access_condition` resource
 - Add support for nested conditions to `ise_network_access_policy_set` resource and data source
 - Add `agentless_posture` attribute to `ise_authorization_profile` resource and data source
-- Add `identity_groups`, `custom_attributes`, `expiry_date_enabled` and `expiry_date` attributes to `ise_internal_user` resource and data source
+- Add `identity_groups` and `custom_attributes` attributes to `ise_internal_user` resource and data source
 - Add support for nested conditions to `ise_network_access_authentication_rule` resource and data source
 - Add support for nested conditions to `ise_network_access_authorization_rule` resource and data source
 - Add `ise_trustsec_egress_matrix_cell` resource and data source

diff --git a/docs/data-sources/internal_user.md b/docs/data-sources/internal_user.md
@@ -34,8 +34,6 @@ data "ise_internal_user" "example" {
 - `email` (String) Email address
 - `enable_password` (String) This field is added in ISE 2.0 to support TACACS+
 - `enabled` (Boolean) Whether the user is enabled/disabled
-- `expiry_date` (String) Password expiry date. It's format is = 'YYYY-MM-DD'
-- `expiry_date_enabled` (Boolean) Enable a password expiry date
 - `first_name` (String) First name of the internal user
 - `identity_groups` (String) Comma separated list of identity group IDs.
 - `last_name` (String) Last name of the internal user

diff --git a/docs/guides/changelog.md b/docs/guides/changelog.md
@@ -12,7 +12,7 @@ description: |-
 - Fix issue with reading nested conditions using `ise_network_access_condition` resource
 - Add support for nested conditions to `ise_network_access_policy_set` resource and data source
 - Add `agentless_posture` attribute to `ise_authorization_profile` resource and data source
-- Add `identity_groups`, `custom_attributes`, `expiry_date_enabled` and `expiry_date` attributes to `ise_internal_user` resource and data source
+- Add `identity_groups` and `custom_attributes` attributes to `ise_internal_user` resource and data source
 - Add support for nested conditions to `ise_network_access_authentication_rule` resource and data source
 - Add support for nested conditions to `ise_network_access_authorization_rule` resource and data source
 - Add `ise_trustsec_egress_matrix_cell` resource and data source

diff --git a/docs/resources/internal_user.md b/docs/resources/internal_user.md
@@ -25,7 +25,6 @@ resource "ise_internal_user" "example" {
   first_name             = "John"
   last_name              = "Doe"
   password_id_store      = "Internal Users"
-  expiry_date_enabled    = false
   description            = "My first Terraform user"
 }
 ```
@@ -48,9 +47,6 @@ resource "ise_internal_user" "example" {
 - `email` (String) Email address
 - `enable_password` (String) This field is added in ISE 2.0 to support TACACS+
 - `enabled` (Boolean) Whether the user is enabled/disabled
-- `expiry_date` (String) Password expiry date. It's format is = 'YYYY-MM-DD'
-- `expiry_date_enabled` (Boolean) Enable a password expiry date
-  - Default value: `false`
 - `first_name` (String) First name of the internal user
 - `identity_groups` (String) Comma separated list of identity group IDs.
 - `last_name` (String) Last name of the internal user

diff --git a/examples/resources/ise_internal_user/resource.tf b/examples/resources/ise_internal_user/resource.tf
@@ -10,6 +10,5 @@ resource "ise_internal_user" "example" {
   first_name             = "John"
   last_name              = "Doe"
   password_id_store      = "Internal Users"
-  expiry_date_enabled    = false
   description            = "My first Terraform user"
 }
diff --git a/gen/definitions/internal_user.yaml b/gen/definitions/internal_user.yaml
@@ -80,25 +80,23 @@ attributes:
     description: The ID store where the internal user's password is kept
     default_value: Internal Users
     example: Internal Users
-  - model_name: expiryDateEnabled
-    data_path: [InternalUser]
-    tf_name: expiry_date_enabled
-    type: Bool
-    description: Enable a password expiry date
-    default_value: false
-    example: false
-  - model_name: expiryDate
-    data_path: [InternalUser]
-    tf_name: expiry_date
-    type: String
-    description: Password expiry date. It's format is = 'YYYY-MM-DD'
-    example: "2024-12-11"
-    exclude_test: true
+    # expiryDate works with PUT but fails with POST
+  # - model_name: expiryDateEnabled
+  #   data_path: [InternalUser]
+  #   tf_name: expiry_date_enabled
+  #   type: Bool
+  #   description: Enable a password expiry date
+  #   default_value: false
+  #   example: false
+  # - model_name: expiryDate
+  #   data_path: [InternalUser]
+  #   tf_name: expiry_date
+  #   type: String
+  #   description: Password expiry date. It's format is = 'YYYY-MM-DD'
+  #   example: "2024-12-11"
+  #   exclude_test: true
   - model_name: description
     data_path: [InternalUser]
     type: String
     description: Description
     example: My first Terraform user
-
-
-
diff --git a/internal/provider/data_source_ise_internal_user.go b/internal/provider/data_source_ise_internal_user.go
diff --git a/internal/provider/data_source_ise_internal_user_test.go b/internal/provider/data_source_ise_internal_user_test.go
diff --git a/internal/provider/model_ise_internal_user.go b/internal/provider/model_ise_internal_user.go
diff --git a/internal/provider/resource_ise_internal_user.go b/internal/provider/resource_ise_internal_user.go
diff --git a/internal/provider/resource_ise_internal_user_test.go b/internal/provider/resource_ise_internal_user_test.go
diff --git a/templates/guides/changelog.md.tmpl b/templates/guides/changelog.md.tmpl
@@ -12,7 +12,7 @@ description: |-
 - Fix issue with reading nested conditions using `ise_network_access_condition` resource
 - Add support for nested conditions to `ise_network_access_policy_set` resource and data source
 - Add `agentless_posture` attribute to `ise_authorization_profile` resource and data source
-- Add `identity_groups`, `custom_attributes`, `expiry_date_enabled` and `expiry_date` attributes to `ise_internal_user` resource and data source
+- Add `identity_groups` and `custom_attributes` attributes to `ise_internal_user` resource and data source
 - Add support for nested conditions to `ise_network_access_authentication_rule` resource and data source
 - Add support for nested conditions to `ise_network_access_authorization_rule` resource and data source
 - Add `ise_trustsec_egress_matrix_cell` resource and data source