Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lh-89397): add optional software_version and asdm_version params to cdo_asa_device #154

Merged
merged 8 commits into from
Jan 21, 2025

Conversation

siddhuwarrier
Copy link
Collaborator

https://jira-eng-rtp3.cisco.com/jira/browse/LH-89397
https://jira-eng-rtp3.cisco.com/jira/browse/LH-89401

Description

Add optional software_version and asdm_version fields to the cdo_asa_device resource.

  • If software_version or asdm_version are specified on a resource being created, the Terraform provider will validate whether the version specified matches the version of the actual ASA. If not it will fail.
  • We do the same for asdm_version

Coming soon:

  • You will be able to change the version of the ASA during update, and trigger an upgrade.

@siddhuwarrier siddhuwarrier requested a review from talhazi January 20, 2025 16:23
Copy link
Collaborator

@talhazi talhazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When creating an ASA device through the UI, we do not provide those versions, so why do we want to support that through the Terraform provider?
Besides that - LGTM!

@siddhuwarrier siddhuwarrier merged commit 201fbec into main Jan 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants