Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lh-86968): add terraform resource to add user groups to MSP-managed tenant #152

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

siddhuwarrier
Copy link
Collaborator

https://jira-eng-rtp3.cisco.com/jira/browse/LH-86968

Description

Allow an MSP admin to use terraform to add user groups to a tenant managed by the MSP portal. TODO:
acceptance tests

…ged tenant

Allow an MSP admin to use terraform to add user groups to a tenant managed by the MSP portal. TODO:
acceptance tests
Copy link
Collaborator

@talhazi talhazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, small ones

client/internal/url/url.go Show resolved Hide resolved
client/client.go Show resolved Hide resolved
client/msp/usergroups/delete.go Show resolved Hide resolved
client/msp/usergroups/read.go Show resolved Hide resolved
client/msp/usergroups/read.go Show resolved Hide resolved
Copy link
Collaborator

@talhazi talhazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siddhuwarrier siddhuwarrier merged commit 688b711 into main Nov 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants