[minor_change] Add resources and datasources to support qosDot1PClass and qosDscpClass and expose them in existing aci_custom_qos_policy resource and datasource as children (DCNE-35)

[akinross]

fixes #1267

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 89.97240% with 218 lines in your changes missing coverage. Please review.

Project coverage is 83.97%. Comparing base (9e2dfc6) to head (51407b9).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/provider/resource_aci_dot1p_classifier.go	85.71%	67 Missing and 25 partials ⚠️
...rnal/provider/resource_aci_dscp_to_priority_map.go	85.71%	67 Missing and 25 partials ⚠️
...nternal/provider/resource_aci_custom_qos_policy.go	97.59%	8 Missing and 4 partials ⚠️
...ernal/provider/data_source_aci_dot1p_classifier.go	92.30%	9 Missing and 2 partials ⚠️
...l/provider/data_source_aci_dscp_to_priority_map.go	92.30%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
+ Coverage   83.74%   83.97%   +0.22%     
==========================================
  Files         123      127       +4     
  Lines       56180    58384    +2204     
==========================================
+ Hits        47049    49026    +1977     
- Misses       7255     7423     +168     
- Partials     1876     1935      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gmicol]

have you tried to see what happens with these class objects when priority is set to unspecified?

[akinross]

have you tried to see what happens with these class objects when priority is set to unspecified?

just double checked and it sets to unspecified for both classes, also checked the target_cos attribute

[shrsr]

LGTM

[gmicol]

LGTM

[sajagana]

Suggested change

	- "Tenants -> Policies -> Protocol -> Custom QoS -> DSCP to priority ap"
	- "Tenants -> Policies -> Protocol -> Custom QoS -> DSCP to priority map"

[shrsr]

LGTM

[sajagana]

LGTM!

[gmicol]

LGTM

[samiib]

LGTM