-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenBSD node definition and build instructions. #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good, and I'm pleased you incorporated cloud-init for provisioning support!
Might I suggest, instead of asking one to install the packages like mtr--
ahead of time, should an example in your cloud-init provisioning. You might also consider defaulting the cloud-init for networking to be DHCP.
As for locations for images, we're not setup for large file handling here. Maybe a Google Drive or S3 bucket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I really appreciate all the work you've done here. I had a couple more readme comments.
Overall -- while the instruction for building this is quite detailed -- I think the user community would find it extremely valuable to have a pre-built image. I don't own this repo, so I can't enable LFS, but let me see if I can spin up another repo for images.
node-definitions/openbsd/README.md
Outdated
|
||
* RAM: 1GB | ||
* Disk: 8GB | ||
* CPU: Single |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should specify this as:
CPU: 1
node-definitions/openbsd/README.md
Outdated
* RAM: 1GB | ||
* Disk: 8GB | ||
* CPU: Single | ||
* Network: single interface with Internet access |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the use cases you spell out above is router. Your node def file does provide for multiple interfaces. Your default if count is 2. Why state a single interface here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the 'Create the VM' section to address this.
Actually, I think LFS might be a bit problematic for people. If you send me your qcow2, I'll host it. |
Email sent with URL. |
Please be brutally honest with this PR. My goal is to both contribute and improve. If there's anything that is unclear, unwanted, or sub-standard please let me know so that I can fix it.
Also - is there a good place to put image binaries?
Thanks!