VPC Pair 4.x Implementation#197
Conversation
|
Continuation of sivakasi-cisco#1 |
sivakasi-cisco
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
plugins/module_utils/endpoints/v1/manage/vpc_pair_base_paths.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/endpoints/v1/manage_vpc_pair/vpc_pair_endpoints.py
Outdated
Show resolved
Hide resolved
plugins/module_utils/endpoints/v1/manage/vpc_pair_base_paths.py
Outdated
Show resolved
Hide resolved
| - VpcPairResourceService handles NDStateMachine orchestration | ||
| - Custom actions use RestSend (NDModuleV2) for HTTP with retry logic | ||
| """ | ||
| argument_spec = dict( |
There was a problem hiding this comment.
We decided that it would be better to include this as part of our pydantic models and update argument_spec from the model.
Here is an example:
This should be added to the pydantic model that represents your playbook configuration. I did not see one for your playbook configuration so for now you could add it to the vpc_pair_models.py file but we should discuss adding a pydantic model the represents the playbook config the user would provide.
| ) | ||
|
|
||
| # State-specific parameter validations | ||
| state = module.params.get("state", "merged") |
There was a problem hiding this comment.
Curious why you default to merged here since the argument spec above already defaults state to merged?
| deploy = module.params.get("deploy") | ||
| dry_run = module.params.get("dry_run") | ||
|
|
||
| if state == "gathered" and deploy: |
There was a problem hiding this comment.
We need to discuss this more for this module but state: gathered must adhere to the playbook ansible argument spec so that it can be cut an pasted into a playbook
This should follow the Ansible argspec and if used in a playbook with state overridden would result in no changes to the controller
There was a problem hiding this comment.
Let's discuss alternatives to what you are doing since I believe you are using your current version of state: gathered for testing
sivakasi-cisco
changed the title
sivakasi-cisco
changed the title
sivakasi-cisco
force-pushed
the
vpc_pair_4x_nd
branch
2 times, most recently
from
47f5bb0 to
ea2e89c
Compare
1. Fix deploy timeout in merge\ 2. Check modules gathered output for ebgp vpc pair list 3. Remove delete in bulk as its not required for vpc\ 4. cleanups from the review comments expected 5. Fine tuning IT
…se by default and Correcting the IT accordingly
- resuse existing mixins without more duplicates\ - Adding type annotations to method signatures - revisited the required imports and removed others
- run time inputs for verify instead of suppress_verification - verify_option/query timers changed as config_action with retries - config_action validation - config_save knob along with deploy - limited external fabric checks for gathered calls - explicit field comparison readded in merge - vpc_pair details check extended - sanity checks, UT additions
sivakasi-cisco
force-pushed
the
vpc_pair_4x_nd
branch
from
f0a3132 to
7da587f
Compare
4 participants
#230
vPC Pair support for ND 4.x
nd_manage_vpc_pair can create, update, delete, override, and gather vPC pairs.
The big module logic was split into focused helper files (query, validation, actions, deploy, etc.)
We added dedicated vPC Pair endpoints/models/schemas and connected them through the orchestrator + state machine flow.
Integration tests were added across all main scenarios (merge/replace/override/delete/gather).