Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed cloud site tasks from test files (DCNE-233) #593

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removed cloud site tasks from test files (DCNE-233) #593

wants to merge 3 commits into from

Conversation

sajagana
Copy link
Collaborator

@sajagana sajagana commented Jan 9, 2025

No description provided.

@sajagana sajagana self-assigned this Jan 9, 2025
@sajagana sajagana added the jira-sync Sync this issue to Jira label Jan 9, 2025
@github-actions github-actions bot changed the title Removed cloud site tasks from test files Removed cloud site tasks from test files (DCNE-271) Jan 9, 2025
@sajagana sajagana changed the title Removed cloud site tasks from test files (DCNE-271) Removed cloud site tasks from test files (DCNE-233) Jan 9, 2025
anvitha-jain
anvitha-jain previously approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@anvitha-jain anvitha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sajagana sajagana dismissed stale reviews from akinross, shrsr, and anvitha-jain via 1025afe January 14, 2025 12:03
@sajagana
[ignore] Removed cloud sites from the mso_schema_site_contract_servic…
17502bd 
…e_graph module tasks and removed cloud site details from inventory.networking file
@sajagana sajagana force-pushed the 233_remove_could_tasks branch from 1025afe to 17502bd Compare January 14, 2025 12:10
@lhercot lhercot removed the jira-sync Sync this issue to Jira label Jan 14, 2025
shrsr
shrsr previously approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment on thread above

@sajagana sajagana requested a review from akinross January 31, 2025 11:15
@sajagana sajagana requested a review from shrsr January 31, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@samiib samiib Awaiting requested review from samiib samiib is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@akinross akinross Awaiting requested review from akinross akinross is a code owner

@shrsr shrsr Awaiting requested review from shrsr shrsr is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@sajagana sajagana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sajagana @shrsr @akinross @anvitha-jain @samiib @lhercot