Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_change] Add ndo_tenant_custom_qos_policy for tenant Custom QoS configuration. (DCNE-127) #571

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[minor_change] Add ndo_tenant_custom_qos_policy for tenant Custom QoS configuration. (DCNE-127) #571

wants to merge 6 commits into from

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Nov 22, 2024

fixes #453

@gmicol gmicol added enhancement New feature or request jira-sync Sync this issue to Jira labels Nov 22, 2024
@gmicol gmicol self-assigned this Nov 22, 2024
@gmicol gmicol requested a review from samiib November 25, 2024 18:32
@gmicol gmicol force-pushed the mso_custom_qos_policy branch from c45f5cf to a719f0c Compare November 26, 2024 14:08
akinross
akinross requested changes Nov 28, 2024
View reviewed changes
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Show resolved Hide resolved
@gmicol gmicol force-pushed the mso_custom_qos_policy branch from 56cd354 to c0c938f Compare December 3, 2024 05:53
@gmicol gmicol requested a review from akinross December 3, 2024 05:53
akinross
akinross previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmicol gmicol force-pushed the mso_custom_qos_policy branch from c0c938f to 372d39b Compare December 3, 2024 10:52
@gmicol gmicol requested a review from akinross December 3, 2024 10:55
akinross
akinross previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr requested changes Dec 3, 2024
View reviewed changes
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
@gmicol gmicol requested review from shrsr and akinross December 4, 2024 08:59
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 25 lines in your changes missing coverage. Please review.

Project coverage is 72.08%. Comparing base (f65f3d0) to head (fdbcbf2).

Files with missing lines Patch % Lines
plugins/modules/ndo_tenant_custom_qos_policy.py 71.25% 13 Missing and 10 partials ⚠️
plugins/module_utils/utils.py 83.33% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   72.58%   72.08%   -0.50%     
==========================================
  Files          55       55              
  Lines        5504     5524      +20     
  Branches     1462     1468       +6     
==========================================
- Hits         3995     3982      -13     
- Misses       1174     1196      +22     
- Partials      335      346      +11
Flag Coverage Δ
integration 72.08% <73.68%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmicol added 5 commits December 5, 2024 07:13
@gmicol
[minor_change] Add ndo_tenant_custom_qos_policy for tenant Custom QoS…
a527796 
… configuration.
@gmicol
[ignore] Change Documentation and attributes name. Add function to co…
33efdaa 
…nvert pyhton list of dict into equivalent NDO API format.
@gmicol
[ignore] Make Documentation clearer for ndo_tenant_custom_qos_policy.…
db5dfea 
… Adjust format_list_dict function in module_utils/utils.py.
@gmicol
[ignore] Correct Grammar and Spelling in Documentation for ndo_tenant…
841756e 
…_custom_qos_policy.py and utils.py.
@gmicol
[ignore] Implement append_update_ops_data function into ndo_tenant_cu…
3a931b6 
…stom_qos_policy module. Modify test case, documentation and format_list_dict in utils.py.
@gmicol gmicol force-pushed the mso_custom_qos_policy branch from fdbcbf2 to 3a931b6 Compare December 5, 2024 13:47
sajagana
sajagana requested changes Dec 6, 2024
View reviewed changes
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Outdated Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Show resolved Hide resolved
plugins/modules/ndo_tenant_custom_qos_policy.py Show resolved Hide resolved
@gmicol gmicol requested a review from sajagana December 6, 2024 15:23
sajagana
sajagana previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

shrsr
shrsr previously approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmicol gmicol dismissed stale reviews from shrsr and sajagana via e4efa20 December 10, 2024 13:15
@gmicol gmicol force-pushed the mso_custom_qos_policy branch from 3cda83e to e4efa20 Compare December 10, 2024 13:15
sajagana
sajagana requested changes Dec 10, 2024
View reviewed changes
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
@gmicol
[ignore] Modify format_list_dict function in utils.py. Slightly modif…
ca954fb 
…y ndo_tenant_custom_qos_policy module's documentation.
@gmicol gmicol force-pushed the mso_custom_qos_policy branch from e4efa20 to ca954fb Compare December 10, 2024 13:40
@gmicol gmicol requested review from sajagana and shrsr December 10, 2024 13:41
shrsr
shrsr approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

akinross
akinross approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib approved these changes Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiib samiib samiib approved these changes

@sajagana sajagana sajagana approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

Assignees

@gmicol gmicol

Labels
enhancement New feature or request jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: New module for Custom QoS Policy in Tenant Tenant Policies Template (DCNE-127)
5 participants
@gmicol @shrsr @akinross @sajagana @samiib