Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

gmicol · 2024-09-27T17:56:11Z

resolves #466

New Modules Added:

ndo_port_channel_interface

gmicol · 2024-10-07T17:27:03Z

To all reviewers, the test is not complete yet as I am waiting for the ndo_interface_setting module to be merged. Please review accordingly. thanks!

plugins/modules/ndo_port_channel_interface.py

tests/integration/targets/ndo_port_channel_interface/tasks/main.yml

plugins/modules/ndo_port_channel_interface.py

tests/integration/targets/ndo_port_channel_interface/tasks/main.yml

plugins/modules/ndo_port_channel_interface.py

plugins/module_utils/mso.py

plugins/modules/ndo_port_channel_interface.py

codecov · 2024-10-23T20:54:37Z

Codecov Report

Attention: Patch coverage is 14.87603% with 103 lines in your changes missing coverage. Please review.

Project coverage is 17.75%. Comparing base (f65f3d0) to head (763afc2).

Files with missing lines	Patch %	Lines
plugins/modules/ndo_port_channel_interface.py	16.32%	82 Missing ⚠️
plugins/module_utils/mso.py	5.55%	17 Missing ⚠️
plugins/module_utils/template.py	20.00%	4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f65f3d0) and HEAD (763afc2). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (f65f3d0) HEAD (763afc2)

integration 1 0

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #539       +/-   ##
===========================================
- Coverage   72.58%   17.75%   -54.83%     
===========================================
  Files          55       93       +38     
  Lines        5504     8826     +3322     
  Branches     1462     2329      +867     
===========================================
- Hits         3995     1567     -2428     
- Misses       1174     7258     +6084     
+ Partials      335        1      -334

Flag	Coverage Δ
integration	`?`
sanity	`17.75% <14.87%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

samiib

LGTM

akinross

LGTM

…riptions for payload data. Modify Documentation and add more examples using uuid.

el_interfaces.

…rt_channel_interface.py module to be consistent with future modules.

…l_interface module. enhance format_interface_descriptions function to format range of interface IDs.

shrsr

LGTM

…nel_interface module. Modify Documentation, Example sections and code logic for interface_descriptions attribute.

shrsr

LGTM

sajagana

LGTM!

akinross

LGTM

…dule when handling null value.

sajagana

LGTM!

shrsr

LGTM

samiib

LGTM

akinross

LGTM

gmicol added enhancement New feature or request jira-sync Sync this issue to Jira labels Sep 27, 2024

gmicol self-assigned this Sep 27, 2024

gmicol force-pushed the mso_port_channel_interface branch from 6a28890 to 5016d36 Compare October 7, 2024 17:07

gmicol requested review from lhercot, shrsr, akinross, anvitha-jain, sajagana and samiib October 7, 2024 17:27

akinross requested changes Oct 8, 2024

View reviewed changes

gmicol force-pushed the mso_port_channel_interface branch from 8a0ef1a to 7f88d0a Compare October 11, 2024 14:39

gmicol requested a review from akinross October 11, 2024 14:39

akinross requested changes Oct 14, 2024

View reviewed changes

gmicol requested a review from akinross October 15, 2024 17:50

anvitha-jain requested changes Oct 18, 2024

View reviewed changes

plugins/modules/ndo_port_channel_interface.py Outdated Show resolved Hide resolved

shrsr requested changes Oct 18, 2024

View reviewed changes

plugins/modules/ndo_port_channel_interface.py Outdated Show resolved Hide resolved

plugins/modules/ndo_port_channel_interface.py Outdated Show resolved Hide resolved

gmicol force-pushed the mso_port_channel_interface branch from 0af57d3 to d5a18f8 Compare October 21, 2024 17:54

gmicol requested review from shrsr and anvitha-jain October 21, 2024 17:55

gmicol force-pushed the mso_port_channel_interface branch 2 times, most recently from 027e458 to eb8cf29 Compare October 21, 2024 17:58

samiib requested changes Oct 23, 2024

View reviewed changes

plugins/module_utils/mso.py Outdated Show resolved Hide resolved

plugins/modules/ndo_port_channel_interface.py Show resolved Hide resolved

gmicol requested a review from samiib October 23, 2024 17:15

gmicol force-pushed the mso_port_channel_interface branch from eb8cf29 to 108465f Compare October 23, 2024 17:38

samiib previously approved these changes Oct 24, 2024

View reviewed changes

akinross previously approved these changes Oct 24, 2024

View reviewed changes

gmicol added 4 commits December 5, 2024 09:01

[ignore] Add function in module_utils/mso.py to format interface_desc…

66a03d6

…riptions for payload data. Modify Documentation and add more examples using uuid.

[ignore] Add a few extra assessments in test file for ndo_port_chann

f0f4c3d

el_interfaces.

[ignore] Changed logics, Documentation and Example sections in ndo_po…

e39b3c3

…rt_channel_interface.py module to be consistent with future modules.

[ignore] Modify Documentation, required attributes in ndo_port_channe…

0993687

…l_interface module. enhance format_interface_descriptions function to format range of interface IDs.

gmicol dismissed akinross’s stale review via c3b633b December 6, 2024 14:24

gmicol force-pushed the mso_port_channel_interface branch 2 times, most recently from c3b633b to bdf92e3 Compare December 6, 2024 14:26

gmicol requested a review from akinross December 6, 2024 14:26

gmicol force-pushed the mso_port_channel_interface branch from bdf92e3 to 4316408 Compare December 6, 2024 14:28

shrsr previously approved these changes Dec 9, 2024

View reviewed changes

gmicol dismissed shrsr’s stale review via c5fd99a December 10, 2024 09:38

gmicol force-pushed the mso_port_channel_interface branch from 4316408 to c5fd99a Compare December 10, 2024 09:38

gmicol requested a review from shrsr December 10, 2024 09:38

[ignore] Implement append_update_ops_data function into ndo_port_chan…

263ef9a

…nel_interface module. Modify Documentation, Example sections and code logic for interface_descriptions attribute.

gmicol force-pushed the mso_port_channel_interface branch from c5fd99a to 263ef9a Compare December 10, 2024 13:12

shrsr previously approved these changes Dec 10, 2024

View reviewed changes

sajagana previously approved these changes Dec 11, 2024

View reviewed changes

akinross previously approved these changes Dec 11, 2024

View reviewed changes

gmicol dismissed stale reviews from akinross, sajagana, and shrsr via 227262d December 11, 2024 09:57

gmicol force-pushed the mso_port_channel_interface branch from 227262d to b2d05b4 Compare December 11, 2024 10:00

[ignore] Modify test case and logic for ndo_port_channel_interface mo…

9f40b3b

…dule when handling null value.

gmicol force-pushed the mso_port_channel_interface branch from b2d05b4 to 9f40b3b Compare December 11, 2024 10:20

sajagana approved these changes Dec 12, 2024

View reviewed changes

gmicol requested review from akinross and shrsr December 12, 2024 09:12

shrsr approved these changes Dec 13, 2024

View reviewed changes

samiib approved these changes Dec 13, 2024

View reviewed changes

akinross approved these changes Dec 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

gmicol commented Sep 27, 2024

gmicol commented Oct 7, 2024

codecov bot commented Oct 23, 2024 •

edited

Loading

samiib left a comment

akinross left a comment

shrsr left a comment

shrsr left a comment

sajagana left a comment

akinross left a comment

sajagana left a comment

shrsr left a comment

samiib left a comment

akinross left a comment

Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

Are you sure you want to change the base?

Add a new module to manage Port Channel Interfaces in Fabric Resource Policies Template. (DCNE-52) #539

Conversation

gmicol commented Sep 27, 2024

gmicol commented Oct 7, 2024

codecov bot commented Oct 23, 2024 • edited Loading

Codecov Report

samiib left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

sajagana left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

sajagana left a comment

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 23, 2024 •

edited

Loading