Use inherited constructors instead of constructor delegation

sf::Exception can use the inheriting constructors functionality instead of a constructor delegating to the parent constructor. I removed Exception.cpp as it is not needed anymore.
ChrisThrasher · Oct 5, 2024 · 72207a6 · 72207a6
1 parent 9169e11
commit 72207a6
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 46 deletions.
diff --git a/include/SFML/System/Exception.hpp b/include/SFML/System/Exception.hpp
@@ -41,12 +41,6 @@ namespace sf
 class SFML_SYSTEM_API Exception : public std::runtime_error
 {
 public:
-    ////////////////////////////////////////////////////////////
-    /// \brief Construct with message
-    ///
-    /// \param message Exception message
-    ///
-    ////////////////////////////////////////////////////////////
-    explicit Exception(const std::string& message);
+    using std::runtime_error::runtime_error;
 };
 } // namespace sf
diff --git a/src/SFML/System/CMakeLists.txt b/src/SFML/System/CMakeLists.txt
@@ -10,7 +10,6 @@ set(SRC
     ${SRCROOT}/EnumArray.hpp
     ${SRCROOT}/Err.cpp
     ${INCROOT}/Err.hpp
-    ${SRCROOT}/Exception.cpp
     ${INCROOT}/Exception.hpp
     ${INCROOT}/Export.hpp
     ${INCROOT}/InputStream.hpp

diff --git a/src/SFML/System/Exception.cpp b/src/SFML/System/Exception.cpp