Skip to content

Commit

Permalink
Don't mark public constants as static
Browse files Browse the repository at this point in the history
  • Loading branch information
ChrisThrasher committed Sep 23, 2024
1 parent 78df3c3 commit 344246f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions include/SFML/Window/Joystick.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@ namespace sf::Joystick
///
////////////////////////////////////////////////////////////
// NOLINTBEGIN(readability-identifier-naming)
static constexpr unsigned int Count{8}; //!< Maximum number of supported joysticks
static constexpr unsigned int ButtonCount{32}; //!< Maximum number of supported buttons
static constexpr unsigned int AxisCount{8}; //!< Maximum number of supported axes
constexpr unsigned int Count{8}; //!< Maximum number of supported joysticks
constexpr unsigned int ButtonCount{32}; //!< Maximum number of supported buttons
constexpr unsigned int AxisCount{8}; //!< Maximum number of supported axes
// NOLINTEND(readability-identifier-naming)

////////////////////////////////////////////////////////////
Expand Down
4 changes: 2 additions & 2 deletions include/SFML/Window/Keyboard.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ enum class Key
///
////////////////////////////////////////////////////////////
// NOLINTNEXTLINE(readability-identifier-naming)
static constexpr unsigned int KeyCount{static_cast<unsigned int>(Key::Pause) + 1};
constexpr unsigned int KeyCount{static_cast<unsigned int>(Key::Pause) + 1};

////////////////////////////////////////////////////////////
/// \brief Scancodes
Expand Down Expand Up @@ -333,7 +333,7 @@ using Scancode = Scan;
///
////////////////////////////////////////////////////////////
// NOLINTNEXTLINE(readability-identifier-naming)
static constexpr unsigned int ScancodeCount{static_cast<unsigned int>(Scan::LaunchMediaSelect) + 1};
constexpr unsigned int ScancodeCount{static_cast<unsigned int>(Scan::LaunchMediaSelect) + 1};

////////////////////////////////////////////////////////////
/// \brief Check if a key is pressed
Expand Down
2 changes: 1 addition & 1 deletion include/SFML/Window/Mouse.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ enum class Button
};

// NOLINTNEXTLINE(readability-identifier-naming)
static constexpr unsigned int ButtonCount{5}; //!< The total number of mouse buttons
constexpr unsigned int ButtonCount{5}; //!< The total number of mouse buttons

////////////////////////////////////////////////////////////
/// \brief Mouse wheels
Expand Down
2 changes: 1 addition & 1 deletion include/SFML/Window/Sensor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ enum class Type
};

// NOLINTNEXTLINE(readability-identifier-naming)
static constexpr unsigned int Count{6}; //!< The total number of sensor types
constexpr unsigned int Count{6}; //!< The total number of sensor types

////////////////////////////////////////////////////////////
/// \brief Check if a sensor is available on the underlying platform
Expand Down

0 comments on commit 344246f

Please sign in to comment.