Add pcntl extension and improve installation of others #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pcntl module is one of several slated [to be moved out of core](https://wiki.php.net/rfc/unbunle-unmaintained-extensions-php8) in php8, so it now needs to be installed/enabled manually. This fixes the "Error: PHP extension pcntl is required for enforcing time limits" warning that's triggered by ShellCommandBuilder's tests.
This significantly reduces the complexity of extension installation by utilising the docker-php-ext-* helper scripts provided by the php image. Those scripts cd to /usr/src/php/ext where all the other core extensions are kept, so by cloning there we save a lot of directory jumping too. The -ext-install script will also add the `extension=*` line, so that's removed from the custom xhprof.ini to avoid duplicate loading warnings.
Updates the application group step to use the variable when adding it to sudoers to avoid issues if those variables are changed, and makes use of PHP_INI_DIR which is already set to /usr/local/etc/php in the php image.
Updates the xdebug step similarly to the previous pcov/xhprof steps to use the docker-php-ext-* scripts for installation. Rather than manually extracting the archive, we can simply clone the given tag. Since we're using --depth 1 for all the clones, it won't fetch unecessary history. Also removes the chmod which doesn't seem to be needed when the dir is created directly within the container instead of being a volume.
dshoreman
changed the title
ChrisB9
approved these changes
Oct 31, 2020
|
Thank you, those changes look really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8 will remove the pcntl extension from core so it has to be installed manually to get the timing functionality working in phpsu/ShellCommandBuilder#17. While figuring out how to do that, I noticed the other extension steps could also be improved so it's a slightly bigger PR than planned.
Change Summary
--depth 1to allgit clonecommandscd $ext && phpize && ./configure --foowithdocker-php-ext-configure $ext --foomake && make install [&& docker-php-ext-enable]withdocker-php-ext-install[zend_]extension=foo.solines from xhprof and xdebug configsdocker-php-ext-installThe helper scripts can be found in docker-library/php.