Route core Taskdeck review instructions to global canon - #1546
Conversation
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
|
Self-review at exact head |
…icy-canon Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
|
Exact-head adversarial review at
These are the single batched fix round. The separately audited #1544 remainder and three nonblocking stale phrases stay tracked on #1544; they are not part of this fix push. After the fix, rerun only affected local gates, restart exact-head CI, and run one final fresh-context review because the risk boundary changed. |
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ea024d7a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Final independent review — PASS Exact base: The final fresh-context pass confirmed both previously reported HIGH findings are resolved:
New CRITICAL findings: 0. New lower-severity findings: 0. Any later head or base change invalidates this evidence and requires re-proving the affected gate. |
Summary
review-and-shipskillImplementation notes
pre-merge-gateinto a Taskdeck evidence collector that fails closed unless local HEAD, a clean worktree, the remote PR head, the fetched current base, and the merge base all match exactlyTests added or updated
Commands run and results
rg -n -isweep over active root/runtime/agentic instructions returned 287 candidate linesrg -n -iobsolete-signature sweep over the original 12 changed paths returnedAFTER_RG_OBSOLETE_MATCHES=0333d0ba25df53b9b2900840dc2e234e4fc72e84cwith signed mergeb7b4d09ef6ddfe3b44d44aa68e43641c80015331; no conflicts and the pre-fix stable patch ID remained618f6ba59841284e9da1c40ffc3f9b21b2d28b5f6ea024d7a78b83a7eda636211e4d2ca200d7f061; tree2f9a19334ca0a09f166c342e52b858d1333f522cnode scripts/check-docs-governance.mjs— passed on exact fix headnode scripts/check-golden-principles.mjs— passed on exact fix headnode scripts/check-github-ops-governance.mjs— passed on exact fix headpy -3 -B scripts/agent_hooks/smoke_test.py— passed on exact fix headgit diff --check origin/main...HEAD— passed on exact fix headquick_validate.pyfor affectedtaskdeck-worktree-issue-worker— valid on exact fix headpre-merge-gateBash block — syntax passed; dirty-worktree and wrong-PR-head deny canaries passed; exact-head/current-base allow canary passed after pushf39f0cc3a3c3e70a35659e4296e814b2925a28f0,b7b4d09ef6ddfe3b44d44aa68e43641c80015331, and6ea024d7a78b83a7eda636211e4d2ca200d7f061containSigned-off-by:Docs updated
docs/STATUS.mdordocs/IMPLEMENTATION_MASTERPLAN.md; shipped product reality and roadmap sequencing did not change in this PRRisks and follow-ups
This is intentionally a bounded first slice. #1544 remains open.
Confirmed mechanical remainder (11 files):
CLAUDE.md.claude/README.md.claude/settings.jsondocs/ISSUE_EXECUTION_GUIDE.mddocs/tooling/CODEX_AUTONOMY_RUNBOOK.md.codex/config.tomldocs/WORKTREE_AGENT_PROTOCOL.mddocs/QA_STRATEGY.mddocs/STATUS.mddocs/IMPLEMENTATION_MASTERPLAN.mdCODEOWNERSAlso tracked for later under #1544:
docs/ops/DEPENDENCY_UPDATE_POLICY.mdThe legacy Claude skill files retain their pre-existing
user-invocablefrontmatter, which the generic Codex skill validator does not accept; Codex mirrors were validated with that tool, while Claude files are covered by the repository docs checks, Bash syntax/canary proof where applicable, and focused manual inspection.Refs #1544
Refs Chris0Jeky/agent-harness#101
Refs #1291
Refs #1269