Skip to content

Route core Taskdeck review instructions to global canon - #1546

Merged
Chris0Jeky merged 3 commits into
mainfrom
issue-1544/review-policy-canon
Jul 29, 2026
Merged

Route core Taskdeck review instructions to global canon#1546
Chris0Jeky merged 3 commits into
mainfrom
issue-1544/review-policy-canon

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary

Implementation notes

  • removes local reviewer counts, severity bars, fix/re-review rules, bot triggers/waits, tier-row copies, and merge-action ownership from the approved 12-file first slice
  • makes implementation workers return a ready PR plus exact evidence to the coordinator; only the coordinator enters or re-enters the canonical pipeline, and workers resume only for pipeline-directed fixes
  • changes pre-merge-gate into a Taskdeck evidence collector that fails closed unless local HEAD, a clean worktree, the remote PR head, the fetched current base, and the merge base all match exactly
  • does not add a scanner, parity gate, meta-gate, or strategic policy

Tests added or updated

  • none; this is an instruction/routing cleanup

Commands run and results

  • before inventory: one broad rg -n -i sweep over active root/runtime/agentic instructions returned 287 candidate lines
  • after inventory: targeted rg -n -i obsolete-signature sweep over the original 12 changed paths returned AFTER_RG_OBSOLETE_MATCHES=0
  • refreshed onto exact green base 333d0ba25df53b9b2900840dc2e234e4fc72e84c with signed merge b7b4d09ef6ddfe3b44d44aa68e43641c80015331; no conflicts and the pre-fix stable patch ID remained 618f6ba59841284e9da1c40ffc3f9b21b2d28b5f
  • exact fix head: 6ea024d7a78b83a7eda636211e4d2ca200d7f061; tree 2f9a19334ca0a09f166c342e52b858d1333f522c
  • node scripts/check-docs-governance.mjs — passed on exact fix head
  • node scripts/check-golden-principles.mjs — passed on exact fix head
  • node scripts/check-github-ops-governance.mjs — passed on exact fix head
  • py -3 -B scripts/agent_hooks/smoke_test.py — passed on exact fix head
  • git diff --check origin/main...HEAD — passed on exact fix head
  • Codex quick_validate.py for affected taskdeck-worktree-issue-worker — valid on exact fix head
  • extracted pre-merge-gate Bash block — syntax passed; dirty-worktree and wrong-PR-head deny canaries passed; exact-head/current-base allow canary passed after push
  • DCO: all branch commits f39f0cc3a3c3e70a35659e4296e814b2925a28f0, b7b4d09ef6ddfe3b44d44aa68e43641c80015331, and 6ea024d7a78b83a7eda636211e4d2ca200d7f061 contain Signed-off-by:

Docs updated

  • updated active agent manuals, workflow skills, and the root canonical-policy pointer
  • did not update docs/STATUS.md or docs/IMPLEMENTATION_MASTERPLAN.md; shipped product reality and roadmap sequencing did not change in this PR

Risks and follow-ups

This is intentionally a bounded first slice. #1544 remains open.

Confirmed mechanical remainder (11 files):

  1. CLAUDE.md
  2. .claude/README.md
  3. .claude/settings.json
  4. docs/ISSUE_EXECUTION_GUIDE.md
  5. docs/tooling/CODEX_AUTONOMY_RUNBOOK.md
  6. .codex/config.toml
  7. docs/WORKTREE_AGENT_PROTOCOL.md
  8. docs/QA_STRATEGY.md
  9. docs/STATUS.md
  10. docs/IMPLEMENTATION_MASTERPLAN.md
  11. CODEOWNERS

Also tracked for later under #1544:

The legacy Claude skill files retain their pre-existing user-invocable frontmatter, which the generic Codex skill validator does not accept; Codex mirrors were validated with that tool, while Claude files are covered by the repository docs checks, Bash syntax/canary proof where applicable, and focused manual inspection.

Refs #1544
Refs Chris0Jeky/agent-harness#101
Refs #1291
Refs #1269

Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>

Copy link
Copy Markdown
Owner Author

Self-review at exact head f39f0cc3a3c3e70a35659e4296e814b2925a28f0 against base 3ee5a8bf9e2774fd39a70858a92b81ef648cde4a: reviewed the issue boundary, 12-file diff, Claude/Codex/Fable entry and return semantics, PR link semantics, and the local proving evidence. No CRITICAL/HIGH merge-blocking findings. The PR correctly uses Refs #1544 and has no closing issue reference. Residual scope is the five-file remainder listed in the PR body; exact-head hosted checks and automatic independent review remain pending at this checkpoint. No merge requested or performed.

…icy-canon

Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Exact-head adversarial review at b7b4d09ef6ddfe3b44d44aa68e43641c80015331 found 2 HIGH blockers:

  1. Implementation workers can enter and complete the shipping pipeline before coordinator reconciliation. The changed Claude/Codex worker instructions (and the same changed issue-to-pr handoff) tell implementation workers to enter review-and-ship. At Taskdeck's merge-free T3 authority, that creates a direct path to a stacked child or ordinary PR merging before coordinator dependency ordering, project/docs reconciliation, and final synthesis. Fix contract: implementation workers return a ready PR plus exact evidence to the coordinator; only the coordinator enters/re-enters the canonical pipeline, resuming the worker solely for pipeline-directed fixes.

  2. pre-merge-gate can certify checks run against the wrong commit. It is now the canonical pipeline's Taskdeck evidence packet, but it fetches only branch names and never proves local HEAD == headRefOid or merge-base/base OID before running tests. The coordinator checkout can therefore test base while reporting a complete PR-head packet. Fix contract: retrieve head/base OIDs, require execution from the exact-head worktree, fetch/compare the base, and fail closed before tests on any mismatch.

These are the single batched fix round. The separately audited #1544 remainder and three nonblocking stale phrases stay tracked on #1544; they are not part of this fix push. After the fix, rerun only affected local gates, restart exact-head CI, and run one final fresh-context review because the risk boundary changed.

Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ea024d7a7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .claude/skills/pre-merge-gate/SKILL.md
Comment thread .claude/skills/pre-merge-gate/SKILL.md
Comment thread .codex/skills/taskdeck-worktree-issue-worker/SKILL.md
Comment thread .claude/skills/pre-merge-gate/SKILL.md
Comment thread docs/agentic/OVERNIGHT_LOOP.codex.md
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Final independent review — PASS

Exact base: 333d0ba25df53b9b2900840dc2e234e4fc72e84c
Exact head: 6ea024d7a78b83a7eda636211e4d2ca200d7f061

The final fresh-context pass confirmed both previously reported HIGH findings are resolved:

  • Worker/coordination boundaries now return exact evidence to the coordinator; only the coordinator enters or re-enters the shipping pipeline.
  • The pre-merge gate now fails closed unless its clean local checkout matches the live PR head and fetched base/merge-base exactly before running tests.

New CRITICAL findings: 0. New lower-severity findings: 0. Any later head or base change invalidates this evidence and requires re-proving the affected gate.

@Chris0Jeky
Chris0Jeky merged commit 1aad17b into main Jul 29, 2026
21 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Jul 29, 2026
@Chris0Jeky
Chris0Jeky deleted the issue-1544/review-policy-canon branch July 29, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant