Repair merged review-doctrine gate regressions - #1534
Conversation
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
…doctrine Signed-off-by: Chris0Jeky <jeky.tck@gmail.com> # Conflicts: # docs/IMPLEMENTATION_MASTERPLAN.md # docs/STATUS.md
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Review-fix evidence — exact head
|
|
@codex review |
|
Project-state verification (fresh read after writes): issue #1532 = |
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2b991f8d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Final fix-round evidence — exact head
|
|
@codex review |
Disputed review-lens scope line — declined/informationalThe |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9607d10f0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec264ebc42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3db668ce73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ine-gaps Signed-off-by: Chris0Jeky <jeky.tck@gmail.com> # Conflicts: # docs/agentic/OVERNIGHT_LOOP.claude.md # docs/agentic/OVERNIGHT_LOOP.codex.md
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e70341a51
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| If any comment lacks a recorded disposition from the global `review-and-ship` pipeline, report the | ||
| PR as blocked and stop. This gate does not create a separate finding-disposition or fix loop. |
There was a problem hiding this comment.
When a PR has any ordinary informational comment—such as a successful bot notice, status update, or maintainer note—this condition blocks it because such comments naturally have no review-and-ship finding disposition. The surrounding checks and lines 81–84 only require dispositions for actionable findings, so retain that narrower scope rather than making every issue or review comment a permanent merge blocker.
AGENTS.md reference: AGENTS.md:L5-L7
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed HIGH / merge blocker. The condition directly converts normal status, bot-success, and maintainer notes into permanent blockers. The bounded two-round pipeline is exhausted, so this remains unresolved and the PR is parked; #1532 owns the repair.
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f2000136a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## Delivery update (2026-07-27, agentic review-doctrine consolidation) | ||
|
|
||
| - **Single review-workflow home (`#1531` merged; remediation `#1532` / PR `#1534`):** Taskdeck's local instructions, skills, overnight manuals, and PR-create hook are reduced to routing, Taskdeck-specific lenses, and repository mechanics while the estate-wide `review-and-ship` skill owns the executable pipeline. PR `#1531` landed before two HIGH and six MEDIUM exact-head review findings were repaired; the bounded remediation restores the issue-to-PR external-state contract, the mandatory T3 independent pass, policy-neutral Fable/pre-merge/worker/hook routing, runtime-mirror risk-lens parity, and current documentation. This supersedes the review/aging portion of `#1269` without rewriting historical delivery records. The live `.codex` mirror is retained until its separately tracked retirement under `#1291`. |
There was a problem hiding this comment.
The claimed single-home transition remains incomplete for normal contributors: CONTRIBUTING.md:284-304 is the active pull-request process, and lines 300-301 still require a separate reviewer-style self-review before requesting review. Anyone following that entrypoint therefore receives parallel review doctrine instead of routing the PR directly to review-and-ship; update that instruction before recording the local workflow as reduced to routing and repository mechanics.
AGENTS.md reference: AGENTS.md:L5-L7
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed HIGH / merge blocker for this executable instruction change. The active contributor entrypoint still mandates a parallel reviewer-style loop, directly preserving the review rabbit hole this PR claims to remove. No third fix cascade: the PR is parked and #1532 owns the repair.
| Immediately after the local checks, rerun the Step 1 PR query, every Step 2 comment/review/thread | ||
| read through its final cursor, and `gh pr checks`. This is the final external-state snapshot used by | ||
| the verdict. Compare its `headRefOid` and `baseRefOid` with the initial values. If either OID changed, |
There was a problem hiding this comment.
When the base or head changes after Step 4's opening PR query but before the comment, thread, and check reads finish, this procedure has no closing query with which to detect that change and can validate evidence against the obsolete OIDs. Fresh evidence beyond the earlier refresh fix is that the implemented sequence performs the Step 1 query only once at the start of the multi-request snapshot while nevertheless claiming it can detect changes during that snapshot; re-read and compare the OIDs after the final external-state request before issuing the verdict.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed HIGH / merge blocker after independent current-base review. Without a closing OID/mergeability read, a concurrent push or base move can combine stale H1 identity with later H2 comments/checks and incorrectly declare readiness. This remains unresolved under parked #1532.
Parked after bounded final review — exact head
|
1 participant
Important
PARKED at exact head
f2000136a6dd75a6961b067311ec5746e80b86f8; do not merge.The final exact-head connector pass and an independent current-base re-review found three unresolved merge blockers: ordinary informational comments are treated as undisposed findings;
CONTRIBUTING.mdstill routes contributors through a duplicate self-review workflow; and the multi-request final snapshot has no closing OID/mergeability read to detect concurrent head/base drift. A fourth MEDIUM finding concerns brittle prose-based smoke assertions and is tracked by #1544's one-time cleanup.The bounded pipeline has exhausted its two review/fix rounds. Per the convergence ceiling, this PR stays open and ready-for-review with the blocker threads visible; #1532 owns the remaining repair. Green hosted checks do not override the parked review verdict.
Summary
Repair the review-doctrine gaps that PR #1531 merged before its findings were addressed, now reconciled with current
main.review-and-shippipeline while retaining Taskdeck-specific lenses and local proving checksCurrent-base repair — exact head
f2000136a6dd75a6961b067311ec5746e80b86f8Base:
3ee5a8bf9e2774fd39a70858a92b81ef648cde4aA signed merge of current
mainresolved the two overnight-manual conflicts without restoring a copied tier row. The bounded fix rounds repaired these previously confirmed merge blockers:review-and-shipafter Taskdeck-local checks and use its merge action only when the pipeline and declared authority permit.f2000136. Both manuals now delegate post-push eligibility/observation to the canonical pipeline without copying a duration or polling rule; smoke rejects the obsolete waiver.Secrets scan: CLEAN: valid but non-blocking; tracked as [Gate] Derive the pre-merge secrets verdict from real scan evidence #1543 with fail-closed acceptance criteria instead of expanding this HIGH-only fix round.The 12 pre-final-review threads have recorded dispositions and are resolved. Four exact-head threads remain: three confirmed merge blockers parked under #1532, plus one non-blocking smoke-hardening finding tracked by #1544. The existing hook smoke matrix exercises the attempted final-snapshot, reviewer-independence, canonical-merge-handoff, and post-push-delegation contracts.
Exact-head local verification
py -3 -B scripts/agent_hooks/smoke_test.py— PASS (Hook behavior smoke matrix passed)node scripts/check-docs-governance.mjs— PASSnode scripts/check-golden-principles.mjs— PASSnode scripts/check-github-ops-governance.mjs— PASSgit diff --check— PASSSigned-off-by:f2000136— completed with PARK verdict and three merge blockersBackend, frontend, and Playwright suites were not run locally: no product source, project file, workflow, or UI behavior changed. Hosted required lanes remain the integration gate.
Documentation
docs/STATUS.mdupdateddocs/IMPLEMENTATION_MASTERPLAN.mdupdateddocs/REVIVAL_PLAN.mdand affected execution/runbook surfaces remain aligneddocs/TESTING_GUIDE.md/ manual checklist — not applicable to this instruction/hook-only behavior changeRisk and follow-ups
The changed surface is executable agent instruction and gate behavior, not documentation-only. Residual risk is instruction interpretation drift; exact smoke contracts, fresh independent review, cursor-complete comment triage, and hosted checks are the merge gate. #1543 owns truthful secrets-verdict evidence, #1544 owns the bounded one-time policy-copy cleanup, #1291 owns eventual Codex-mirror retirement, and #1269 retains its non-review scope.
Closes #1532