Disable automatic staging gate release trigger - #1502
Conversation
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ec17437a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Independent adversarial review #2 — security / governance / testsExact head reviewed: I first inspected the PR conversation, reviews, and review threads, plus linked issue #1228 and its existing maintainer comment. At posting time the PR has the MEDIUM
Existing-feedback triageThe Codex DCO thread is invalid for this exact head: it cites Other reviewed surfaces
|
Independent adversarial review #1 — correctness / operational semanticsReviewed exact head Inspected: the PR body; linked issue #1228 and its existing comment; every current PR conversation comment, review submission, and inline thread; the complete six-file patch; the full staging workflow; adjacent CRITICALNone. HIGHNone. MEDIUM
LOW
Existing feedback disposition
Trigger and regression conclusionRemoving the |
Summary
Testing
Documentation
Outstanding Maintainer Checklist
|
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Review finding resolution ?
|
|
@codex review |
Summary
Testing
Outstanding Maintainer ChecklistNo
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af8bbeee2b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Independent security/governance re-reviewExact head: I inspected all seven conversation comments, both review submissions, both inline threads, linked #1228 and its comment, the complete seven-file base-to-head diff, the full workflow and governance script, live environment/project state, and exact-head checks. CRITICAL / HIGHNone. MEDIUM
LOW
Verified fixes and unchanged safeguards
Existing-comment dispositionThe owner’s |
Summary
Testing
Outstanding Maintainer WorkThe durable checklist remains open, including |
Independent exact-head re-review #1 — correctness / operational semanticsHead: Before reviewing the final diff, I inspected all eight current conversation comments, both review submissions, both inline threads, linked #1228 plus its comment, and #1504. I then inspected the complete seven-file base-to-head diff, the full workflow/checker/docs, live environment and ProjectV2 state, the PR commit set, and exact-head checks. CRITICAL / HIGHNone. MEDIUM
LOW
Prior-finding resolution verdict
Current-head conclusionThe actual workflow is |
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Review-fix evidence — exact head
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 239625530e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Independent security/governance exact-head re-review — findings remainHead: I inspected all 12 conversation comments, all three review submissions, all five inline threads, linked #1228 and its maintainer comment, #1504, the complete ten-file base-to-head diff, the four-file fix commit, the full workflow/checker/tests/docs, live environments and ProjectV2 state, the four-commit set, and exact-head checks. CRITICAL / HIGHNone. MEDIUM
LOW
Verified fixes and unchanged safeguards
Exact-head checks / residual riskAt the final pre-post refresh: 32 checks succeeded, 5 were skipped, 0 were neutral, and 3 were still running; no completed check had failed. Docs Governance, Workflow Lint, and DCO were green. No release event or manual staging dispatch was emitted, and no environment approval was exercised. Those live operations remain intentionally unverified while the path is parked. The three current Codex threads are valid and must be addressed under the repository review policy before this head is merge-ready. |
Independent exact-head re-review #1 — correctness follow-upBefore opening the new commit, I read all 13 current conversation comments, all three review submissions, and all five inline threads, plus #1228 and #1504. I then reviewed the complete ten-file base-to-head diff and the four-file af8bbee..2396255 fix, and ran the exact-head checker/tests plus independent Actionlint-valid adversarial fixtures. CRITICAL / HIGHNone. MEDIUM
LOW
Prior-finding resolution verdict
Exact-head evidence / residual riskExact-head unit tests passed 8/8; the production governance, docs-governance, and golden-principles checks passed; both changed workflows passed pinned Actionlint; and git diff --check passed. The adversarial fixtures above also pass pinned Actionlint while the governance validator returns success. At the immediate pre-post refresh, exact-head CI had 33 successes, 5 skips, 2 jobs still running, and no failures. No release event, manual staging dispatch, or environment approval was exercised. The checked-in workflow itself is safe today, but this head is not merge-ready because its required persistent proof remains fail-open and the current all-severity review findings are unresolved. |
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
|
Fix evidence for exact head
Verification on this exact commit:
The exact-block invariant is intentionally strict for this parked workflow: any future trigger/input change must be a deliberate checker-and-test change, while Actionlint remains the YAML semantics backstop. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5c3c1c593
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Independent governance/security exact-head review — findingsHead: Before reviewing the final diff, I inspected all 16 conversation comments, all eight review submissions, all five inline threads (all currently resolved), linked #1228 and its maintainer comment, and the complete 11-file/five-commit patch. CRITICAL / HIGHNone. MEDIUM
LOW
Existing-feedback disposition
Exact-head evidence / CI state
Immediately before posting, exact-head checks showed 24 successes, 4 skips, 2 jobs still running, and no failures. Pending CI is not itself a finding. No release event, manual staging run, or environment approval was exercised. |
Independent correctness/regression exact-head review - corroborated findingHead: I inspected all 16 conversation comments then present, all eight review submissions, all five inline threads and replies, linked #1228 and #1504, all five commits, and the complete 11-file patch before reviewing. A parallel review posted while I was running the fixture; this is an independent reproduction of the same root cause. MEDIUM
LOW
Existing feedback / exact-head evidence
Final pre-post CI: 25 succeeded / 5 skipped / 9 running / 0 failed. Pending CI is status, not a defect. No live release event, staging dispatch, or environment approval was exercised. |
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
|
Final review-finding fix evidence for exact head
Exact-head local proof:
This is the final fix round. The original two lenses are being asked only to verify this reported defect on the exact head; any further non-critical finding parks the PR under the review-loop ceiling. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Scoped final-fix verification — digest fix passes; one existing thread remainsExact head: I refreshed all 20 conversation comments, nine review submissions, and all six inline threads before testing only the final fix. Reported findings
Exact-head verification
Current unresolved feedbackThe current Codex P2 thread about manual-path runnability is valid and separate from the digest fix. With Therefore the canonical “available for deliberate operator runs” claim remains unproved/false on a clean runner, and the thread is still unresolved. Under the declared final-fix ceiling, this is the non-critical concern to park or track rather than silently treating the PR as comment-clean. No additional concern was found in the scoped |
Independent scoped final-fix verification - fix passes, PR parksExact head: I refreshed the complete PR conversation, reviews, and all six inline threads, then inspected only signed commit
Exact-head local results: governance tests 13/13; GitHub-operations governance, docs governance, golden principles, pinned Actionlint, and diff check all passed. Park dispositionThe existing current Codex P2 thread is valid, separate, and still unresolved. Running the workflow-equivalent Compose validation with only Under the declared final-fix ceiling this confirmed non-critical concern parks the PR; it must not be treated as comment-clean. The exact-head Codex no-major-issues notice is informational and does not resolve that thread. Pre-post hosted state: 20 succeeded / 4 skipped / 6 running / 0 failed. Pending CI is status, not a defect. |
…igger Signed-off-by: Chris0Jeky <jeky.tck@gmail.com> # Conflicts: # docs/IMPLEMENTATION_MASTERPLAN.md
Base reconciliation evidence — exact head
|
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…igger Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
|
Stack refresh evidence for exact head
No workflow dispatch, environment configuration, deployment, retarget, or merge was performed. Please review this exact head: @codex review. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
…igger Signed-off-by: Chris0Jeky <jeky.tck@gmail.com>
Post-#1516 base refresh — exact head
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f42151a2f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| export function retainsReleaseEventHandling(workflowText) { | ||
| const normalizedReferences = workflowText.toLowerCase().replace(/[^a-z0-9_]+/g, '.') | ||
| return normalizedReferences.includes('event_name') || normalizedReferences.includes('github.event.release') |
There was a problem hiding this comment.
When a later reviewed manual-only edit uses github.event_name for a workflow_dispatch condition, diagnostic, or summary, this predicate returns true solely because event_name appears; even after updating the expected digest, Required Docs Governance then falsely reports retained release handling and blocks CI. Restrict this check to references actually compared with release (while continuing to detect github.event.release) rather than banning the event-name context entirely.
Useful? React with 👍 / 👎.
1 participant
Closes #1228
Summary
release: publishedsubscription and unreachable release-event tag handling from the parked staging workflowReview finding follow-up
Blocked / Priority II) in GitHub and the unchecked human-action listVerification
node --test scripts/check-github-ops-governance.test.mjs— 13/13 passednode scripts/check-docs-governance.mjs— passednode scripts/check-golden-principles.mjs— passednode scripts/check-github-ops-governance.mjs— passedrhysd/actionlint:1.7.12on the checked-in workflow — passedreleasetrigger remains Actionlint-valid and is rejected by the digest regressiongit diff --check— passedNot verified
productionenvironment