Complete system-info compatibility with Steam System Information and ProtonDB #236
Conversation
Add xorg-dpyinfo to the PACKAGES manifest so that the proposed changes to system-info (ChimeraOS/chimera#236) closely match what Steam System Information generates.
|
Great work! Two things I noticed while testing:
|
flexiondotorg
force-pushed
the
system-info
branch
from
712f396 to
631017d
Compare
|
@alkazar I've forced pushed a fix for |
flexiondotorg
force-pushed
the
system-info
branch
from
631017d to
c1d11a3
Compare
|
@alkazar The form factor is gathered via |
flexiondotorg
force-pushed
the
system-info
branch
from
c1d11a3 to
cabe9a4
Compare
|
|
||
| # Dump data | ||
| for CMD in glxinfo xdpyinfo xrandr; do |
There was a problem hiding this comment.
We should make chimera dependent on xdpyinfo for this or at least an optional dependency. Maybe the script should check if it present?
There was a problem hiding this comment.
The script does check for the availability of xdpyinfo 🙂 First here:
https://github.com/flexiondotorg/chimera/blob/system-info/bin/system-info#L27
Then here:
https://github.com/flexiondotorg/chimera/blob/system-info/bin/system-info#L75
And here:
https://github.com/flexiondotorg/chimera/blob/system-info/bin/system-info#L101
I also submitted a pull request to update the PACKAGE manifest here:
There was a problem hiding this comment.
Great. Thanks for that.
The package dependency should be managed in packaging of chimera app. Not necessary to add to the image, would be added by pacman when needed.
…ProtonDB Extends system-info so it produces output that is 100% compatible with what Steam System Information produces, including the inconsistent double and single character spacing. The resulting output is also compatible with ProtonDB. Best efforts are made to automatically hunt for an accessible DISPLAY. Unlike Steam System Information on Linux, this system-info will correctly identify touch devices and correctly count HDDs and SSDs. - ValveSoftware/steam-for-linux#5881 - ValveSoftware/steam-for-linux#8412 Motivation for creating patch are that system-info might be more useful a general information gathering tool for users reporting issues and that system-info might now be suitable for integrating in the Chimera webapp, allowing ChimeraOS users an easy way to add their consoles to their ProtonDB profile. - ChimeraOS#231 Make the DISPLAY accessibility checks work on Wayland/Xwayland If form factor is empty, report it as unknown. Make the DISPLAY accessibility tests a noop Correct typo
flexiondotorg
force-pushed
the
system-info
branch
from
cabe9a4 to
151e0f7
Compare
|
LGTM. And is a significant improvement, we could use this to show system info on the web interface. |
|
Tested on both big picture and gamepad ui. It is working great. Nice work! |
Extends system-info so it produces output that is 100% compatible with what Steam System Information produces, including the inconsistent double and single character spacing. The resulting output is also compatible with ProtonDB. Best efforts are made to automatically hunt for an accessible DISPLAY.
Unlike Steam System Information on Linux, this system-info will correctly identify touch devices and correctly count HDDs and SSDs.
Motivations for creating this patch are that system-info might be more useful as a general information gathering tool for users reporting issues and that system-info might now be suitable for integrating into the Chimera web app, allowing ChimeraOS users an easy way to add their consoles to their ProtonDB profile.