Add Streaming Control and Configuration page #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it simpler for the user to add inputs as necessary. By default use `x11grab` on input `:0` and `alsa` capture with `pulse` input. This may not be the best solution but we want to make it configurable in a way that the user can add as many inputs as he/she pleases. Audio and video codecs are not used by default but we add them as configurables. They hold the entire line of configuration, meaning the options for each one are set there as well. For network streaming we hardcode `mpegts` as format (the only one supported by SLS) with the option `flush_packets` set to `0` and for local (recording) we hardcode it as `matroska` format and save the `.mkv` file on users's home directory as `screen_yyyymmdd_hhmmss.mkv`.
It lists current inputs and allows to delete existing ones and add new ones by adding the corresponding FFmpeg arguments
Also add logic to handle strings and list for inputs, video and audio codecs.
|
One suggestion: I think we should put the recorded files under |
Done. Seems like a good practice. Now steam-buddy creates that folder and records are saved there. |
Samsagax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to complete #44 with a default sane FFmpeg configuration and options. This is not accessible via the menu awaiting the redesign, but can be accessed by
/streaming/configurl.Make it simpler for the user to add inputs as necessary.
By default use
x11grabon input:0andalsacapture withpulseinput. This may not be the best solution but we want to make it
configurable in a way that the user can add as many inputs and codecs
as he/she pleases.
Audio and video codecs are not used by default but we add them as
configurables. They hold the entire line of configuration, meaning the
options for each one are set there as well.
For network streaming we hardcode
mpegtsas format (the only onesupported by SLS) with the option
flush_packetsset to0and forlocal (recording) we hardcode it as
matroskaformat and save the.mkvfile on users's home directory asscreen_yyyymmdd_hhmmss.mkv.