-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip install fix #6
Conversation
Chilipp
commented
Feb 5, 2019
•
edited
Loading
edited
- Closes Installation with pip and Qt #1, Tests abort on MacOS #8
- Tests passed (for all non-documentation changes)
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 86.11% 88.17% +2.06%
==========================================
Files 26 26
Lines 11247 11313 +66
==========================================
+ Hits 9685 9975 +290
+ Misses 1562 1338 -224
Continue to review full report at Codecov.
|
This commit adds a leaking report for pytest runs and decreases several memory leaks during the test runs
This PR is ready to be merged. It addresses #1 and #8. In particular:
It will be merged if @sgrieve and @ixjlyons are okay with the proposed changes (see #1 (comment) and #8 (comment)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few nitpick comments, but installation with pip works and it looks good to me. I didn't look closely at the testing related changes but I'm assuming CI is more thoroughly checking all that :)
in response to #6 (comment) and #6 (comment)
in response to #6 (comment)
Thanks a lot for your quick response and your time! The suggested changes have been implemented. I will merge this PR now. |