address incremental-serializer fuzzer failures #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12885333243Details
💛 - Coveralls |
arvidn
force-pushed
the
improve-fuzzer
branch
from
26952d1 to
9b31f2b
Compare
arvidn
force-pushed
the
improve-fuzzer
branch
2 times, most recently
from
3c3f013 to
b7e931c
Compare
arvidn
commented
Jan 21, 2025
arvidn
commented
Jan 21, 2025
arvidn
commented
Jan 21, 2025
arvidn
commented
Jan 21, 2025
arvidn
force-pushed
the
improve-fuzzer
branch
from
b7e931c to
dd8aea5
Compare
matt-o-how
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a performance problem in
insert_sentinel()if it's passed a tree that is large because it reuses sub-trees. This case can cause the iteration to pick every tree node to run for a very long time. This change makesinsert_sentinel()only consider nodes once, and skips them the second time they're encountered.Without this change the fuzzer can time out.